Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Feb 22, 2025

Very basic routes page for universal bridge

Screenshot 2025-02-21 at 20 23 30

PR-Codex overview

This PR primarily focuses on enhancing the functionality of the dashboard's routing feature, particularly for bridging tokens between chains. It introduces new components, updates existing ones for better routing, and modifies environment variables for API integration.

Detailed summary

  • Deleted opengraph-image.png.
  • Updated multiple test files to use @playwright/test.
  • Introduced BRIDGE_URL in env.ts.
  • Enhanced getBaseURL function to accept undefined.
  • Added Route type in route.ts.
  • Updated .env.example with new API hosts.
  • Implemented ChainlistPagination and RouteListView components.
  • Created SearchInput, QueryType, and routing logic in page.tsx.
  • Developed RouteListCard and RouteListRow components for displaying routes.
  • Implemented pagination logic in routes-table.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners February 22, 2025 04:23
@linear
Copy link

linear bot commented Feb 22, 2025

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2025

⚠️ No Changeset found

Latest commit: aaa59f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 5:17am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 25, 2025 5:17am
login ⬜️ Skipped (Inspect) Feb 25, 2025 5:17am
thirdweb_playground ⬜️ Skipped (Inspect) Feb 25, 2025 5:17am
wallet-ui ⬜️ Skipped (Inspect) Feb 25, 2025 5:17am

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (514c1a8) to head (22e8222).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6318   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5258     5258           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7695af0
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 261 ms (+15.77% 🔺) 1.2 s
thirdweb (cjs) 121.87 KB (0%) 2.5 s (0%) 470 ms (-4.36% 🔽) 3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 12 ms (-57.25% 🔽) 124 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 14 ms (+13.96% 🔺) 24 ms
thirdweb/react (minimal + tree-shaking) 19.31 KB (0%) 387 ms (0%) 42 ms (-46.28% 🔽) 428 ms

@gregfromstl gregfromstl marked this pull request as draft February 22, 2025 04:41
@gregfromstl gregfromstl added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Feb 22, 2025
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 22, 2025 04:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 22, 2025 04:47 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 22, 2025 04:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 22, 2025 04:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 22, 2025 04:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 22, 2025 04:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 22, 2025 04:50 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 22, 2025 04:50 Inactive
@gregfromstl gregfromstl removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Feb 22, 2025
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 22, 2025 05:02 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 22, 2025 05:02 Inactive
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Feb 25, 2025
Copy link
Contributor Author

gregfromstl commented Feb 25, 2025

Merge activity

  • Feb 24, 11:55 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 24, 11:55 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 24, 11:58 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Lint Packages', 'Unit Tests').
  • Feb 24, 11:59 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 25, 4:59 AM UTC: The merge label 'merge-queue' was removed. This PR will no longer be merged by the Graphite merge queue

Very basic routes page for universal bridge

<img width="1723" alt="Screenshot 2025-02-21 at 20 23 30" src="https://github.com/user-attachments/assets/228bd8e4-78e9-4c5b-8dc7-7c32e25ea1ba" />

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on enhancing the dashboard's routing and pagination functionalities, as well as introducing a bridge URL configuration. It includes updates to testing files, UI components, and server-side logic to improve the overall user experience.

### Detailed summary
- Added `BRIDGE_URL` to `env.ts` for bridge API configuration.
- Updated multiple test files to include `@playwright/test`.
- Introduced `ChainlistPagination` and `RouteListView` components for improved navigation.
- Enhanced `getRoutes` function to fetch routes with parameters.
- Created `RouteListCard` and `RouteListRow` components for displaying routes.
- Implemented search functionality in `SearchInput` component.
- Updated `RoutesData` to handle pagination and display filtered results.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the greg/tool-3503-universal-bridge-routes-page branch from 22e8222 to eac713f Compare February 25, 2025 04:56
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 25, 2025 04:56 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 25, 2025 04:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 25, 2025 04:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 25, 2025 04:56 Inactive
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Feb 25, 2025
@vercel vercel bot temporarily deployed to Preview – thirdweb-www February 25, 2025 05:09 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 25, 2025 05:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 25, 2025 05:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 25, 2025 05:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 25, 2025 05:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 25, 2025 05:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 25, 2025 05:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 25, 2025 05:10 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 25, 2025 05:10 Inactive
@gregfromstl gregfromstl merged commit 150a90c into main Feb 25, 2025
28 of 30 checks passed
@gregfromstl gregfromstl deleted the greg/tool-3503-universal-bridge-routes-page branch February 25, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants