Skip to content

Conversation

@kilavvy
Copy link
Contributor

@kilavvy kilavvy commented Feb 22, 2025

This pull request contains changes to improve clarity, correctness and structure.


PR-Codex overview

This PR focuses on correcting typos and improving comments in the codebase for better clarity and understanding.

Detailed summary

  • Fixed typo in rpc.ts: changed "assgined" to "assigned".
  • Fixed typo in iframe-wallet.ts: changed "trasaction" to "transaction".
  • Fixed typo in ecosystem.ts: changed "parnter" to "partner".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Signed-off-by: kilavvy <[email protected]>
Signed-off-by: kilavvy <[email protected]>
@kilavvy kilavvy requested review from a team as code owners February 22, 2025 17:45
@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2025

⚠️ No Changeset found

Latest commit: b0e8b38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel
Copy link

vercel bot commented Feb 22, 2025

@kilavvy is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 22, 2025
@jnsdls
Copy link
Member

jnsdls commented Feb 24, 2025

thanks!

@jnsdls jnsdls merged commit 95cc74e into thirdweb-dev:main Feb 24, 2025
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants