[SDK] fix: Force pre-EIP1559 transactions on Homeverse chains #6332
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2022141 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
Dashboard
joaquim-verges
changed the title
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
joaquim-verges
force-pushed
the
_thirdweb_fix_Force_pre-EIP1559_transactions_on_Homeverse_chains
branch
from
3ae23b7 to
7f87bbc
Compare
joaquim-verges
force-pushed
the
_thirdweb_fix_Force_pre-EIP1559_transactions_on_Homeverse_chains
branch
from
7f87bbc to
2022141
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| accountContract, | ||
| }); | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)); // pause for a second to prevent race condition | ||
| await new Promise((resolve) => setTimeout(resolve, 3000)); // pause for a second to prevent race condition |
There was a problem hiding this comment.
Replace arbitrary timeout with a proper contract deployment check or increase timeout to 5000ms to ensure contract is fully deployed
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| }); | ||
| return result === EIP_1271_MAGIC_VALUE; | ||
| } catch { | ||
| } catch (err) { |
There was a problem hiding this comment.
Enhance error logging to include more details about the verification failure, such as contract address and signature data
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
joaquim-verges
deleted the
_thirdweb_fix_Force_pre-EIP1559_transactions_on_Homeverse_chains
branch
PR-Codex overview
This PR focuses on enhancing the
thirdwebpackage by adding support for the Homeverse network, improving error handling, and refining gas price checks. It also updates tests and configurations related to currency utilities and login settings.Detailed summary
MismatchButton.tsxandfee-data.ts.verify-hash.tsto log errors during EIP-1271 signature verification.undefinedinestimate-gas-cost.ts.currencies.test.tsxfrom 5 to 7.smart-wallet-integration-v07.test.tsfrom 1s to 3s.getLoginConfigto return a specific configuration for a demo client ID.