[service-utils] fix usageV2 caller #6346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 8ab7fe6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
jnsdls
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on updating the
UsageV2Producerclass in theservice-utilspackage to change the configuration from usingenvironmenttokafkaServers, reflecting a shift in how Kafka server connections are managed.Detailed summary
environment(string) tokafkaServers(string) in theUsageV2Producerclass.kafkaServersis a comma-separated list ofhost[:port]Kafka servers.PR-Codex overview
This PR focuses on refactoring the
service-utilspackage to improve the handling of Kafka server configurations and usage event URLs by replacing theenvironmentvariable with akafkaServersvariable and introducing ausageBaseUrloption.Detailed summary
UsageV2Producerto replaceenvironmentwithkafkaServers.UsageV2Optionstype to includeusageBaseUrlinstead ofenvironment.sendUsageV2Eventsto useusageBaseUrl.PR-Codex overview
This PR focuses on refactoring the
service-utilspackage by replacing theenvironmentproperty withkafkaServersin theUsageV2Producerclass and updating thesendUsageV2Eventsfunction to useusageBaseUrlinstead of a conditional base URL.Detailed summary
environmentwithkafkaServersinUsageV2Producerclass inpackages/service-utils/src/node/usageV2.ts.UsageV2Optionstype to includeusageBaseUrlinstead ofenvironmentinpackages/service-utils/src/cf-worker/usageV2.ts.sendUsageV2Eventsfunction to useoptions.usageBaseUrlfor constructing URLs.