Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Mar 6, 2025

PR-Codex overview

This PR updates the text in the Alerts.tsx component to clarify messaging regarding Account Abstraction and billing requirements for API keys.

Detailed summary

  • Updated alert message to specify that users need to "subscribe to a billing plan" instead of just needing to "add a payment method."
  • Changed instruction from "To use them on Mainnet," to "To enable AA on mainnet chains," for clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested review from a team as code owners March 6, 2025 10:31
@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: ba505f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 10:49am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 6, 2025 10:49am
login ⬜️ Skipped (Inspect) Mar 6, 2025 10:49am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 6, 2025 10:49am
wallet-ui ⬜️ Skipped (Inspect) Mar 6, 2025 10:49am

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 6, 2025
@arcoraven arcoraven added the merge-queue Adds the pull request to Graphite's merge queue. label Mar 6, 2025
Copy link
Contributor Author

arcoraven commented Mar 6, 2025

Merge activity

  • Mar 6, 5:32 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 6, 5:43 AM EST: A user added this pull request to the Graphite merge queue.

@arcoraven arcoraven enabled auto-merge (squash) March 6, 2025 10:32
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.62%. Comparing base (c547164) to head (ba505f9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6427   +/-   ##
=======================================
  Coverage   54.62%   54.62%           
=======================================
  Files         874      874           
  Lines       54743    54743           
  Branches     3711     3711           
=======================================
  Hits        29902    29902           
  Misses      24746    24746           
  Partials       95       95           
Flag Coverage Δ
packages 54.62% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 198 ms (+98.53% 🔺) 1.2 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 318 ms (+29.48% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 71 ms (+837.44% 🔺) 183 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 43 ms (+1755.27% 🔺) 53 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 93 ms (+207.25% 🔺) 479 ms

<!-- start pr-codex -->

## PR-Codex overview
This PR updates the text in the `Alerts.tsx` component to clarify instructions related to Account Abstraction for API keys and billing.

### Detailed summary
- Changed the message about enabling Account Abstraction to specify it is for mainnet chains.
- Updated the action from "add a payment method" to "subscribe to a billing plan."

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the ph/aa-mainnet-message branch from 26b8da9 to ba505f9 Compare March 6, 2025 10:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 6, 2025 10:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 6, 2025 10:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 6, 2025 10:43 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 6, 2025 10:43 Inactive
@jnsdls jnsdls disabled auto-merge March 6, 2025 10:44
@jnsdls jnsdls merged commit 11bb4f5 into main Mar 6, 2025
26 of 27 checks passed
@jnsdls jnsdls deleted the ph/aa-mainnet-message branch March 6, 2025 10:44
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants