Skip to content

[SDK] fix: Handle serialized bigints for packing userops #6490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

[SDK] fix: Handle serialized bigints for packing userops #6490

merged 1 commit into from
Mar 17, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 17, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on handling serialized bigint values for packing user operations in the thirdweb wallet library, ensuring proper conversion and padding of gas limits and other numeric fields.

Detailed summary

  • Updated getAccountGasLimits to convert verificationGasLimit and callGasLimit to BigInt.
  • Updated getGasLimits to convert maxPriorityFeePerGas and maxFeePerGas to BigInt.
  • Modified getPaymasterAndData to handle paymasterVerificationGasLimit and paymasterPostOpGasLimit as BigInt.
  • Changed getPackedUserOperation to convert nonce and preVerificationGas to BigInt.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 11:05pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 11:05pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 11:05pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 11:05pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 11:05pm

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2025

🦋 Changeset detected

Latest commit: f2d07ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 17, 2025
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Mar 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review March 17, 2025 22:58
@joaquim-verges joaquim-verges requested review from a team as code owners March 17, 2025 22:58
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.94 KB (0%) 939 ms (0%) 348 ms (+16.39% 🔺) 1.3 s
thirdweb (cjs) 127.18 KB (0%) 2.6 s (0%) 834 ms (+4% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 141 ms (+341.99% 🔺) 253 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 28 ms (+149.01% 🔺) 38 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 117 ms (+64.66% 🔺) 504 ms

@codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.83%. Comparing base (f2e61b8) to head (f2d07ee).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...kages/thirdweb/src/wallets/smart/lib/packUserOp.ts 75.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6490      +/-   ##
==========================================
+ Coverage   54.80%   54.83%   +0.02%     
==========================================
  Files         875      875              
  Lines       54851    54851              
  Branches     3738     3738              
==========================================
+ Hits        30062    30075      +13     
+ Misses      24695    24681      -14     
- Partials       94       95       +1
Flag Coverage Δ
packages 54.83% <75.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
...kages/thirdweb/src/wallets/smart/lib/packUserOp.ts 89.83% <75.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 9901351 into main Mar 17, 2025
34 of 35 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Handle_serialized_bigints_for_packing_userops branch March 17, 2025 23:24
@joaquim-verges joaquim-verges mentioned this pull request Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges