Skip to content

[SDK] docs: Add example for shouldUpdateSessionKey function #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

[SDK] docs: Add example for shouldUpdateSessionKey function #6491

merged 1 commit into from
Mar 19, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 18, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on updating various package dependencies across multiple applications and components, including updates to lucide-react, prettier, and @chromatic-com/storybook. It also includes improvements to the shouldUpdateSessionKey function documentation.

Detailed summary

  • Updated lucide-react from 0.479.0 to 0.482.0 in multiple package.json files.
  • Updated prettier from 3.3.3 to 3.5.3 in multiple package.json files.
  • Updated @chromatic-com/storybook from 3.2.5 to 3.2.6.
  • Updated @playwright/test from 1.51.0 to 1.51.1.
  • Enhanced documentation for the shouldUpdateSessionKey function with an example.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 6:58am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 6:58am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 6:58am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 6:58am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 6:58am

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 28e87d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. packages Ecosystem Portal Involves changes to the Ecosystem Portal SDK Involves changes to the thirdweb SDK labels Mar 18, 2025
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Mar 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review March 18, 2025 01:59
@joaquim-verges joaquim-verges requested review from a team as code owners March 18, 2025 01:59
@socket-security
Copy link

socket-security bot commented Mar 18, 2025 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@chromatic-com/[email protected] ➜ 3.2.6 Transitive: filesystem +8 6.58 MB ghengeveld
npm/@playwright/[email protected] ➜ 1.51.1 None +2 0 B
npm/[email protected] ➜ 0.11.6 Transitive: environment +36 2.74 MB rafaelrozon, yannbf
npm/[email protected] ➜ 0.482.0 None 0 32.9 MB ericfennis

View full report↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.94 KB (0%) 939 ms (0%) 310 ms (+83.83% 🔺) 1.3 s
thirdweb (cjs) 127.18 KB (0%) 2.6 s (0%) 553 ms (+10.06% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 142 ms (+334.73% 🔺) 254 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 8 ms (+78.72% 🔺) 18 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 104 ms (+211.74% 🔺) 491 ms

@codecov
Copy link

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.81%. Comparing base (2d5ff74) to head (28e87d5).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6491      +/-   ##
==========================================
- Coverage   54.82%   54.81%   -0.01%     
==========================================
  Files         875      875              
  Lines       54851    54851              
  Branches     3740     3740              
==========================================
- Hits        30071    30067       -4     
- Misses      24685    24690       +5     
+ Partials       95       94       -1
Flag Coverage Δ
packages ∅ <ø> (∅)
Files with missing lines Coverage Δ
...eb/src/extensions/erc4337/account/addSessionKey.ts 95.06% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges force-pushed the _SDK_docs_Add_example_for_shouldUpdateSessionKey_function branch from d5bce14 to 28e87d5 Compare March 18, 2025 06:50
@joaquim-verges joaquim-verges merged commit 639b542 into main Mar 19, 2025
33 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_docs_Add_example_for_shouldUpdateSessionKey_function branch March 19, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

Dashboard Involves changes to the Dashboard. Ecosystem Portal Involves changes to the Ecosystem Portal packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges