Skip to content

[Portal] fee-changes #6573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

[Portal] fee-changes #6573

merged 1 commit into from
Mar 27, 2025

Conversation

@saminacodes
Copy link
Member

@saminacodes saminacodes commented Mar 27, 2025 •
edited by pr-codex bot
Loading

CORE-0000

PR-Codex overview

This PR updates the fee structure and related information for the Buy With Crypto and swap transactions in the fee-sharing documentation. It clarifies the fees charged by thirdweb and how developers can set their own fees.

Detailed summary

  • Updated fee from 1% to 0.3% for transactions.
  • Removed mention of 70% fee sharing for Buy With Crypto.
  • Added information on developer fees for swap transactions.
  • Clarified fee structure for buying with crypto and swap fees.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@saminacodes saminacodes requested review from a team as code owners March 27, 2025 22:43
@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 826748b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 11:01pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 11:01pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Mar 27, 2025 11:01pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 27, 2025 11:01pm
wallet-ui ⬜️ Skipped (Inspect) Mar 27, 2025 11:01pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 27, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase. labels Mar 27, 2025
@codecov
Copy link

codecov bot commented Mar 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.06%. Comparing base (d4f5a9d) to head (826748b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6573   +/-   ##
=======================================
  Coverage   55.06%   55.06%           
=======================================
  Files         883      883           
  Lines       55361    55361           
  Branches     3787     3787           
=======================================
  Hits        30486    30486           
  Misses      24780    24780           
  Partials       95       95
Flag Coverage Δ
packages 55.06% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.56 KB (0%) 952 ms (0%) 174 ms (+208.3% 🔺) 1.2 s
thirdweb (cjs) 127.31 KB (0%) 2.6 s (0%) 247 ms (+39.96% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 99 ms (+1800% 🔺) 211 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 41 ms (+2705.12% 🔺) 51 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 99 ms (+761.03% 🔺) 486 ms

@joaquim-verges joaquim-verges changed the title fee-changes [Portal] fee-changes Mar 27, 2025
@saminacodes saminacodes added the merge-queue Adds the pull request to Graphite's merge queue. label Mar 27, 2025
@saminacodes Graphite App
Copy link
Member Author

saminacodes commented Mar 27, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 27, 6:53 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 27, 6:53 PM EDT: saminacodes added this pull request to the Graphite merge queue.
  • Mar 27, 7:01 PM EDT: A user merged this pull request with the Graphite merge queue.

@saminacodes
[Portal] fee-changes (#6573)
826748b 
CORE-0000

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the fee structure and related information for the `Buy With Crypto` and swap transactions in the `fee-sharing` documentation.

### Detailed summary
- Removed references to a 1% fee and 70% sharing for `Buy With Crypto`.
- Updated the protocol fee to 0.3% for swap transactions.
- Allowed developers to set their own additional fees.
- Clarified fee structure for buying with crypto and swap transactions.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 27, 2025 22:54 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 27, 2025 22:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 27, 2025 22:54 Inactive
@graphite-app graphite-app bot merged commit 826748b into main Mar 27, 2025
32 checks passed
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Mar 27, 2025
@graphite-app graphite-app bot deleted the ub-pricing branch March 27, 2025 23:01
@vercel vercel bot temporarily deployed to Production – login March 27, 2025 23:01 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 27, 2025 23:01 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui March 27, 2025 23:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@saminacodes saminacodes

Labels

Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saminacodes @joaquim-verges