-
Notifications
You must be signed in to change notification settings - Fork 623
[SDK] show transfer amounts with fees #6618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: efe7677 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (2.12%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6618 +/- ##
==========================================
+ Coverage 54.92% 54.96% +0.03%
==========================================
Files 885 885
Lines 55577 55603 +26
Branches 3792 3797 +5
==========================================
+ Hits 30527 30563 +36
+ Misses 24955 24945 -10
Partials 95 95
🚀 New features to boost your workflow:
|
...ages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/TransferConfirmationScreen.tsx
Show resolved
Hide resolved
6366ccc to
cf9e69d
Compare
cf9e69d to
4850a02
Compare
4850a02 to
93ad1ae
Compare
93ad1ae to
efe7677
Compare

PR-Codex overview
This PR focuses on enhancing the transfer flow in the
PayEmbedcomponent by correctly displaying the transfer amount and integrating a query for fetching transfer data.Detailed summary
isTransfervariable and related conditional rendering inSwapDetailsScreen.tsx.useQueryfor fetching transfer data inTransferConfirmationScreen.tsx.fromAmountto reflect the correct amount considering fees.