Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 1, 2025


PR-Codex overview

This PR focuses on enhancing the transfer flow in the PayEmbed component by correctly displaying the transfer amount and integrating a query for fetching transfer data.

Detailed summary

  • Removed the isTransfer variable and related conditional rendering in SwapDetailsScreen.tsx.
  • Added a useQuery for fetching transfer data in TransferConfirmationScreen.tsx.
  • Updated fromAmount to reflect the correct amount considering fees.
  • Handled loading state for transfer data with a spinner.
  • Improved error handling for missing transfer data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 2:12am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 2:12am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 2:12am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 2:12am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 2:12am

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

🦋 Changeset detected

Latest commit: efe7677

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 1, 2025
@joaquim-verges joaquim-verges changed the title show transfer amounts with fees [SDK] show transfer amounts with fees Apr 1, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.61 KB (0%) 953 ms (0%) 170 ms (+197.23% 🔺) 1.2 s
thirdweb (cjs) 127.63 KB (0%) 2.6 s (0%) 259 ms (+53.34% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 83 ms (+1351% 🔺) 196 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 55 ms (+2752.45% 🔺) 65 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 388 ms (0%) 124 ms (+799.33% 🔺) 511 ms

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 2.12766% with 46 lines in your changes missing coverage. Please review.

Project coverage is 54.96%. Comparing base (04943d7) to head (efe7677).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...et/screens/Buy/swap/TransferConfirmationScreen.tsx 2.12% 46 Missing ⚠️

❌ Your patch status has failed because the patch coverage (2.12%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6618      +/-   ##
==========================================
+ Coverage   54.92%   54.96%   +0.03%     
==========================================
  Files         885      885              
  Lines       55577    55603      +26     
  Branches     3792     3797       +5     
==========================================
+ Hits        30527    30563      +36     
+ Misses      24955    24945      -10     
  Partials       95       95              
Flag Coverage Δ
packages 54.96% <2.12%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
...screens/Buy/pay-transactions/SwapDetailsScreen.tsx 6.27% <ø> (+0.59%) ⬆️
...et/screens/Buy/swap/TransferConfirmationScreen.tsx 7.48% <2.12%> (-0.46%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants