Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 4, 2025

PR-Codex overview

This PR introduces a new MultiNetworkSelector component and a MultiSelect component with enhanced functionality, including search and display of multiple network options. It also adds a custom hook useShowMore for lazy loading items in the UI.

Detailed summary

  • Added useShowMore hook for lazy loading items.
  • Introduced MultiNetworkSelector component for selecting multiple networks.
  • Enhanced MultiSelect component with search functionality and lazy loading.
  • Updated BlueprintPlayground to utilize MultiNetworkSelector.
  • Modified form handling to accommodate arrays for chain selection.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Apr 4, 2025

@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 4, 2025 16:23 Inactive
@vercel
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 5:47pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 4, 2025 5:47pm
login ⬜️ Skipped (Inspect) Apr 4, 2025 5:47pm
thirdweb-www ⬜️ Skipped (Inspect) Apr 4, 2025 5:47pm
wallet-ui ⬜️ Skipped (Inspect) Apr 4, 2025 5:47pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: 7597418

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login April 4, 2025 16:23 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 4, 2025 16:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 4, 2025 16:23 Inactive
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Apr 4, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (5204bd5) to head (7597418).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6652   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files         889      889           
  Lines       55768    55768           
  Branches     3816     3816           
=======================================
  Hits        30665    30665           
  Misses      25008    25008           
  Partials       95       95           
Flag Coverage Δ
packages 54.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.57 KB (0%) 952 ms (0%) 152 ms (+154.19% 🔺) 1.2 s
thirdweb (cjs) 129.95 KB (0%) 2.6 s (0%) 234 ms (+36.13% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 100 ms (+2360.5% 🔺) 212 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 33 ms (+2276.45% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.37 KB (0%) 388 ms (0%) 86 ms (+382.51% 🔺) 474 ms

@MananTank MananTank marked this pull request as draft April 4, 2025 16:37
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 4, 2025 16:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 4, 2025 16:38 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 4, 2025 16:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 4, 2025 16:38 Inactive
@MananTank MananTank marked this pull request as ready for review April 4, 2025 16:39
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 4, 2025

Merge activity

…6652)

<!-- start pr-codex -->

## PR-Codex overview
This PR introduces a `MultiSelect` component along with a `useShowMore` hook to enhance the selection of network chains in a UI. It improves the user experience by allowing more items to be displayed as the user scrolls and provides a more flexible selection interface.

### Detailed summary
- Added `useShowMore` hook to manage displaying more items on scroll.
- Introduced `MultiNetworkSelector` for selecting multiple network chains.
- Updated `BlueprintPlayground` to utilize `MultiNetworkSelector`.
- Modified `ParameterSection` to handle array values for chain selection.
- Created `MultiSelect` component for better multi-item selection.
- Enhanced UI with search functionality and option rendering in `MultiSelect`.
- Implemented badge display for selected items in `MultiSelect`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 4, 2025 17:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www April 4, 2025 17:46 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 4, 2025 17:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 4, 2025 17:47 Inactive
@graphite-app graphite-app bot merged commit 7597418 into main Apr 4, 2025
31 checks passed
@graphite-app graphite-app bot deleted the tool-3564 branch April 4, 2025 17:51
@vercel vercel bot temporarily deployed to Production – login April 4, 2025 17:51 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 4, 2025 17:51 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www April 4, 2025 17:51 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 4, 2025 17:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants