Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 5, 2025


PR-Codex overview

This PR focuses on refactoring and enhancing the UI components related to token and NFT details, permissions, and analytics in a dashboard application. It includes component renaming, restructuring, and improved styling for better usability and presentation.

Detailed summary

  • Deleted unused files: data.ts, types.ts, TokenDetails.tsx.
  • Renamed StatCard to Stat for consistency.
  • Updated TokenSupply to TokenDetailsCard.
  • Improved layout and styling for various components (e.g., MarketplaceDetails, NFTDetails).
  • Added new storybook entries for components like PermissionsTableUI and LatestEventsUI.
  • Enhanced the structure of NFTCards and LatestEvents components for better responsiveness and clarity.
  • Replaced Chakra UI components with custom UI components for consistency.
  • Updated analytics and event handling in ContractAnalyticsOverviewCard.
  • Improved accessibility and usability with better button placements and loading indicators.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2025

⚠️ No Changeset found

Latest commit: a9eda9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 9:31am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 7, 2025 9:31am
login ⬜️ Skipped (Inspect) Apr 7, 2025 9:31am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 7, 2025 9:31am
wallet-ui ⬜️ Skipped (Inspect) Apr 7, 2025 9:31am

@MananTank MananTank marked this pull request as ready for review April 5, 2025 14:31
@MananTank MananTank requested review from a team as code owners April 5, 2025 14:31
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 5, 2025
Copy link
Member Author

MananTank commented Apr 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank force-pushed the 04-05-dashboard_migrate_contract_overview_page_components_to_tailwind_shadcn_1 branch from 6c35284 to 8fbb110 Compare April 5, 2025 14:32
@vercel vercel bot temporarily deployed to Preview – login April 5, 2025 14:33 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 5, 2025 14:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 5, 2025 14:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 5, 2025 14:33 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.62 KB (0%) 953 ms (0%) 182 ms (+126.39% 🔺) 1.2 s
thirdweb (cjs) 129.82 KB (0%) 2.6 s (0%) 287 ms (+19.17% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 110 ms (+732.38% 🔺) 223 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 49 ms (+1747.17% 🔺) 59 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 133 ms (+524.24% 🔺) 520 ms

@MananTank MananTank force-pushed the 04-05-dashboard_migrate_contract_overview_page_components_to_tailwind_shadcn_1 branch from 8fbb110 to 6417664 Compare April 5, 2025 14:39
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 5, 2025 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 5, 2025 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 5, 2025 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 5, 2025 14:39 Inactive
@MananTank MananTank force-pushed the 04-05-dashboard_migrate_contract_overview_page_components_to_tailwind_shadcn_1 branch from 6417664 to 9e7bb4e Compare April 5, 2025 14:40
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 5, 2025 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 5, 2025 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 5, 2025 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 5, 2025 14:40 Inactive
@MananTank MananTank force-pushed the 04-05-dashboard_migrate_contract_overview_page_components_to_tailwind_shadcn_1 branch from 9e7bb4e to 858c821 Compare April 5, 2025 15:11
@MananTank MananTank force-pushed the 04-05-dashboard_migrate_contract_overview_page_components_to_tailwind_shadcn_1 branch from 35c079d to 379de4b Compare April 5, 2025 17:13
@vercel vercel bot temporarily deployed to Preview – login April 5, 2025 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 5, 2025 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 5, 2025 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 5, 2025 17:13 Inactive
@MananTank MananTank force-pushed the 04-05-dashboard_migrate_contract_overview_page_components_to_tailwind_shadcn_1 branch from 379de4b to 48f8aba Compare April 5, 2025 17:33
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 5, 2025 17:33 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 5, 2025 17:33 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 5, 2025 17:33 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 5, 2025 17:33 Inactive
Base automatically changed from 04-05-dashboard_remove_chakra_usage_from_contract_analytics_page_style_tweaks to main April 7, 2025 09:22
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 7, 2025

Merge activity

…cn (#6662)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring and improving the UI components related to token and NFT details, enhancing the overall structure and user experience in the dashboard application.

### Detailed summary
- Removed unused files: `data.ts`, `types.ts`, and `TokenDetails.tsx`.
- Renamed `StatCard` to `Stat` for consistency.
- Updated UI components to improve layout and styling.
- Enhanced `TokenDetailsCard` and `NFTDetails` for better presentation.
- Added storybook entries for `PermissionsTable` and `LatestEvents`.
- Improved handling of loading states in various components.
- Replaced Chakra UI components with custom UI components for consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-05-dashboard_migrate_contract_overview_page_components_to_tailwind_shadcn_1 branch from 48f8aba to a9eda9f Compare April 7, 2025 09:24
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 7, 2025 09:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 7, 2025 09:24 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 7, 2025 09:24 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 7, 2025 09:24 Inactive
@graphite-app graphite-app bot merged commit a9eda9f into main Apr 7, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 04-05-dashboard_migrate_contract_overview_page_components_to_tailwind_shadcn_1 branch April 7, 2025 09:31
@vercel vercel bot temporarily deployed to Production – wallet-ui April 7, 2025 09:31 Inactive
@vercel vercel bot temporarily deployed to Production – login April 7, 2025 09:31 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 7, 2025 09:31 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 7, 2025 09:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants