Skip to content

Dashboard: Contract page style adjustments, fixes, reduce chakra usage #6664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Dashboard: Contract page style adjustments, fixes, reduce chakra usage #6664

merged 1 commit into from
Apr 7, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 7, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the UI components in the dashboard application, improving styling, and updating text elements for better clarity and consistency.

Detailed summary

  • Updated Button class in primary-dashboard-button.tsx to include background color.
  • Changed headings from <p> to <h2> for better semantic structure in auction and listing pages.
  • Renamed Stat to StatCard in supply-cards.tsx.
  • Improved layout and styling of various components to enhance visual appeal.
  • Updated ownedBalance variable in TokenDetailsCard for clarity.
  • Added a new StatCard component for displaying statistics.
  • Enhanced button styles and interactions in marketplace details.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 1:26pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 7, 2025 1:26pm
login ⬜️ Skipped (Inspect) Apr 7, 2025 1:26pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 7, 2025 1:26pm
wallet-ui ⬜️ Skipped (Inspect) Apr 7, 2025 1:26pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 7, 2025 12:21 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 7, 2025 12:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 7, 2025 12:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 7, 2025 12:21 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 672f7d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank Graphite App
Copy link
Member Author

MananTank commented Apr 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 7, 2025
@MananTank MananTank marked this pull request as ready for review April 7, 2025 12:21
@MananTank MananTank requested review from a team as code owners April 7, 2025 12:21
@codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.05%. Comparing base (a9eda9f) to head (672f7d0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6664   +/-   ##
=======================================
  Coverage   55.05%   55.05%           
=======================================
  Files         889      889           
  Lines       55858    55858           
  Branches     3825     3825           
=======================================
  Hits        30751    30751           
  Misses      25012    25012           
  Partials       95       95
Flag Coverage Δ
packages 55.05% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.62 KB (0%) 953 ms (0%) 216 ms (+136.58% 🔺) 1.2 s
thirdweb (cjs) 129.82 KB (0%) 2.6 s (0%) 290 ms (+19.78% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 70 ms (+1026.18% 🔺) 182 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 41 ms (+1068.9% 🔺) 51 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 80 ms (+315.71% 🔺) 468 ms

@MananTank MananTank force-pushed the 04-07-dashboard_contract_page_style_adjustments_fixes_reduce_chakra_usage branch from fe41f8e to 7ed56e2 Compare April 7, 2025 12:34
@vercel vercel bot temporarily deployed to Preview – login April 7, 2025 12:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 7, 2025 12:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 7, 2025 12:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 7, 2025 12:34 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 7, 2025 •
edited
Loading

Merge activity

@MananTank
Dashboard: Contract page style adjustments, fixes, reduce chakra usage (
672f7d0 
#6664)

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on enhancing the UI components within the dashboard, improving layout consistency, and updating text for better clarity and user experience.

### Detailed summary
- Updated `Button` styles in `primary-dashboard-button.tsx`.
- Increased gap in layout for `ContractOverviewPage.tsx`.
- Changed headings to `h2` for better accessibility in auction and listing pages.
- Introduced `StatCard` component for consistent stats display.
- Renamed `tokenBalanceQuery` to `ownedTokenBalanceQuery` for clarity.
- Updated `SupplyCards` to use `StatCard` instead of `Stat`.
- Improved layout structure with new divs and classes for better styling.
- Added `ArrowRightIcon` to navigation links for visual cues.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-07-dashboard_contract_page_style_adjustments_fixes_reduce_chakra_usage branch from 7ed56e2 to 672f7d0 Compare April 7, 2025 13:19
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 7, 2025 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 7, 2025 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 7, 2025 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 7, 2025 13:19 Inactive
@graphite-app graphite-app bot merged commit 672f7d0 into main Apr 7, 2025
29 of 32 checks passed
@graphite-app graphite-app bot deleted the 04-07-dashboard_contract_page_style_adjustments_fixes_reduce_chakra_usage branch April 7, 2025 13:27
@vercel vercel bot temporarily deployed to Production – wallet-ui April 7, 2025 13:27 Inactive
@vercel vercel bot temporarily deployed to Production – login April 7, 2025 13:27 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 7, 2025 13:27 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 7, 2025 13:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls