Skip to content

[Dashboard] Migrate missing extension overlay from chakra to tailwind css #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

[Dashboard] Migrate missing extension overlay from chakra to tailwind css #6677

merged 1 commit into from
Apr 8, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 8, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the UI components related to settings in a dashboard application by adding overflow="hidden" to Card components and improving the SettingDetectedState component's structure and styling.

Detailed summary

  • Added overflow="hidden" to Card components in multiple files.
  • Refactored SettingDetectedState to a function component with inline props definition.
  • Updated the layout and styling in SettingDetectedState for better responsiveness and design.
  • Replaced SimpleGrid with a div for layout adjustments.
  • Changed text elements to improve semantics and styling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 10:06pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 8, 2025 10:06pm
login ⬜️ Skipped (Inspect) Apr 8, 2025 10:06pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 8, 2025 10:06pm
wallet-ui ⬜️ Skipped (Inspect) Apr 8, 2025 10:06pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 8, 2025 21:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 8, 2025 21:31 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 8, 2025 21:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 8, 2025 21:31 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 8, 2025
@MananTank MananTank mentioned this pull request Apr 8, 2025
Merged
@MananTank Graphite App
Copy link
Member Author

MananTank commented Apr 8, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review April 8, 2025 21:32
@MananTank MananTank requested review from a team as code owners April 8, 2025 21:32
@MananTank MananTank force-pushed the 04-09-_dashboard_migrate_missing_extension_overlay_from_chakra_to_tailwind_css branch from adc1df7 to 98dab9c Compare April 8, 2025 21:33
@graphite-app graphite-app bot changed the base branch from 04-09-_dashboard_contracts_sources_page_migrate_from_chakra_to_tailwind_shadcn to graphite-base/6677 April 8, 2025 21:34
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.62 KB (0%) 953 ms (0%) 139 ms (+59.34% 🔺) 1.1 s
thirdweb (cjs) 129.82 KB (0%) 2.6 s (0%) 285 ms (+14.81% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 80 ms (+871.14% 🔺) 193 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 46 ms (+2191.46% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 98 ms (+426.79% 🔺) 485 ms

@graphite-app graphite-app bot force-pushed the 04-09-_dashboard_migrate_missing_extension_overlay_from_chakra_to_tailwind_css branch from 98dab9c to c1f25e5 Compare April 8, 2025 21:43
@graphite-app graphite-app bot force-pushed the graphite-base/6677 branch from 63642b4 to 8b4091e Compare April 8, 2025 21:43
@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b4e5dc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025

⚠️ No Changeset found

Latest commit: c1f25e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app graphite-app bot changed the base branch from graphite-base/6677 to main April 8, 2025 21:43
@graphite-app graphite-app bot force-pushed the 04-09-_dashboard_migrate_missing_extension_overlay_from_chakra_to_tailwind_css branch from c1f25e5 to f3ad4e2 Compare April 8, 2025 21:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 8, 2025 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 8, 2025 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 8, 2025 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 8, 2025 21:43 Inactive
@codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.05%. Comparing base (8b4091e) to head (b4e5dc1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6677   +/-   ##
=======================================
  Coverage   55.05%   55.05%           
=======================================
  Files         889      889           
  Lines       55858    55858           
  Branches     3825     3825           
=======================================
  Hits        30751    30751           
  Misses      25012    25012           
  Partials       95       95
Flag Coverage Δ
packages 55.05% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 8, 2025 •
edited
Loading

Merge activity

@MananTank
[Dashboard] Migrate missing extension overlay from chakra to tailwind…
b4e5dc1 
… css (#6677)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on enhancing the UI components related to settings by adding `overflow="hidden"` to `Card` components and refining the `SettingDetectedState` component's structure and styling for improved clarity and responsiveness.

### Detailed summary
- Added `overflow="hidden"` to `Card` components in multiple files.
- Refactored `SettingDetectedState` to use a function declaration instead of a functional component type.
- Improved the layout and styling of the loading and error states in `SettingDetectedState`.
- Replaced `SimpleGrid` with a `div` for better control over layout.
- Updated text structure and classes for better styling consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-09-_dashboard_migrate_missing_extension_overlay_from_chakra_to_tailwind_css branch from f3ad4e2 to b4e5dc1 Compare April 8, 2025 22:00
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 8, 2025 22:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 8, 2025 22:00 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 8, 2025 22:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 8, 2025 22:00 Inactive
@graphite-app graphite-app bot merged commit b4e5dc1 into main Apr 8, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 04-09-_dashboard_migrate_missing_extension_overlay_from_chakra_to_tailwind_css branch April 8, 2025 22:07
@vercel vercel bot temporarily deployed to Production – login April 8, 2025 22:07 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 8, 2025 22:07 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 8, 2025 22:07 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 8, 2025 22:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls