Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 11, 2025


PR-Codex overview

This PR introduces a feePayer option for the direct_payment mode in the PayEmbed component, allowing users to specify who will pay the transfer fee—either the sender or the receiver.

Detailed summary

  • Added feePayer option in ConnectButtonProps.ts for direct transfers, accepting "sender" or "receiver".
  • Updated TransferConfirmationScreen.tsx to utilize feePayer based on payment mode.
  • Modified getTransfer.ts to include feePayer in transfer parameters.
  • Enhanced documentation to clarify feePayer usage in the PayEmbed component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 3:45am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 3:45am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 3:45am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 3:45am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 3:45am

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025

🦋 Changeset detected

Latest commit: 6b8d276

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Minor
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review April 11, 2025 03:38
@joaquim-verges joaquim-verges requested review from a team as code owners April 11, 2025 03:38
@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Apr 11, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.67 KB (-0.04% 🔽) 954 ms (-0.04% 🔽) 198 ms (+113.76% 🔺) 1.2 s
thirdweb (cjs) 130.06 KB (+0.04% 🔺) 2.7 s (+0.04% 🔺) 316 ms (+32.11% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 93 ms (+1391.62% 🔺) 205 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 46 ms (+2050.96% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 111 ms (+533.36% 🔺) 499 ms

@joaquim-verges joaquim-verges merged commit 86070fa into main Apr 11, 2025
29 of 32 checks passed
@joaquim-verges joaquim-verges deleted the _Pay_Add_feePayer_option_for_direct_payment_mode_in_PayEmbed branch April 11, 2025 03:43
@joaquim-verges joaquim-verges mentioned this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants