Skip to content

Dashboard: Fix contract overpage page overflow when there are too many events in single tx #6700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Dashboard: Fix contract overpage page overflow when there are too many events in single tx #6700

merged 1 commit into from
Apr 11, 2025
+45 −33

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 11, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the layout and functionality of the ContractOverviewPage and LatestEvents components in a dashboard application. It introduces an overflow property for better layout management and optimizes the event display logic.

Detailed summary

  • Added overflow-hidden class to the outer div in ContractOverviewPage.tsx.
  • Refactored the event mapping logic in LatestEvents.tsx to use a block body for better readability.
  • Introduced a button to display the count of additional events when more than three events are present.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 5:08pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 11, 2025 5:08pm
login ⬜️ Skipped (Inspect) Apr 11, 2025 5:08pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 11, 2025 5:08pm
wallet-ui ⬜️ Skipped (Inspect) Apr 11, 2025 5:08pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 11, 2025 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 11, 2025 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 11, 2025 16:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 11, 2025 16:47 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: af09576

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 11, 2025
@MananTank MananTank marked this pull request as ready for review April 11, 2025 16:47
@MananTank MananTank requested review from a team as code owners April 11, 2025 16:47
@MananTank Graphite App
Copy link
Member Author

MananTank commented Apr 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank force-pushed the 04-11-dashboard_fix_contract_overpage_page_overflow_when_there_are_too_many_events_in_single_tx branch from f373b7d to 770b23f Compare April 11, 2025 16:48
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 11, 2025 16:48 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 11, 2025 16:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 11, 2025 16:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 11, 2025 16:48 Inactive
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Apr 11, 2025 — with Graphite App
@codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.04%. Comparing base (316cef1) to head (af09576).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6700   +/-   ##
=======================================
  Coverage   55.04%   55.04%           
=======================================
  Files         889      889           
  Lines       55870    55870           
  Branches     3820     3820           
=======================================
  Hits        30753    30753           
  Misses      25023    25023           
  Partials       94       94
Flag Coverage Δ
packages 55.04% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MananTank MananTank force-pushed the 04-11-dashboard_fix_contract_overpage_page_overflow_when_there_are_too_many_events_in_single_tx branch from 770b23f to fe71a6e Compare April 11, 2025 16:51
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 11, 2025 16:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 11, 2025 16:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 11, 2025 16:51 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 11, 2025 16:51 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.67 KB (0%) 954 ms (0%) 291 ms (+234.9% 🔺) 1.3 s
thirdweb (cjs) 130.06 KB (0%) 2.7 s (0%) 402 ms (+56.32% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 124 ms (+2095.2% 🔺) 236 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 79 ms (+3132.38% 🔺) 89 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 130 ms (+508.15% 🔺) 518 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 11, 2025 •
edited
Loading

Merge activity

@MananTank
Dashboard: Fix contract overpage page overflow when there are too man…
af09576 
…y events in single tx (#6700)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `ContractOverviewPage` and `LatestEvents` components in a React application by adding overflow handling and improving the display of event data.

### Detailed summary
- Added `overflow-hidden` class to the `div` in `ContractOverviewPage.tsx`.
- Refactored the mapping of `allEvents` in `LatestEvents.tsx` to use a block structure for better readability.
- Limited the displayed events to 3 and added a button to show additional events if more than 3 exist.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 04-11-dashboard_fix_contract_overpage_page_overflow_when_there_are_too_many_events_in_single_tx branch from fe71a6e to af09576 Compare April 11, 2025 17:01
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 11, 2025 17:01 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 11, 2025 17:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 11, 2025 17:01 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 11, 2025 17:01 Inactive
@graphite-app graphite-app bot merged commit af09576 into main Apr 11, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 04-11-dashboard_fix_contract_overpage_page_overflow_when_there_are_too_many_events_in_single_tx branch April 11, 2025 17:09
@graphite-app graphite-app bot removed the hotfix This pull request should be prioritized in the merge queue. label Apr 11, 2025
@vercel vercel bot temporarily deployed to Production – wallet-ui April 11, 2025 17:09 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 11, 2025 17:09 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 11, 2025 17:09 Inactive
@vercel vercel bot temporarily deployed to Production – login April 11, 2025 17:09 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls