You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR focuses on enhancing the getClaimPhasesInLegacyFormat and getClaimConditions functions to support multi-phase claim conditions for ERC20 and ERC721 tokens, improving the handling of single-phase drops.
Detailed summary
Added isMultiPhase to the options parameter in getClaimPhasesInLegacyFormat.
Updated the return statement in getClaimPhasesInLegacyFormat for ERC1155 to include singlePhaseDrop.
Modified getClaimConditions to handle singlePhaseDrop logic.
Removed the use of Promise.allSettled for single-phase claims.
Added error handling for cases where claim conditions are not found.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
DashboardInvolves changes to the Dashboard.packagesSDKInvolves changes to the thirdweb SDK
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
Dashboard
PR-Codex overview
This PR focuses on enhancing the
getClaimPhasesInLegacyFormatandgetClaimConditionsfunctions to support multi-phase claim conditions for ERC20 and ERC721 tokens, improving the handling of single-phase drops.Detailed summary
isMultiPhaseto theoptionsparameter ingetClaimPhasesInLegacyFormat.getClaimPhasesInLegacyFormatforERC1155to includesinglePhaseDrop.getClaimConditionsto handlesinglePhaseDroplogic.Promise.allSettledfor single-phase claims.