Skip to content

Fix dynamic contract publish #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2025
Merged

Fix dynamic contract publish #6729

merged 3 commits into from
Apr 15, 2025

Conversation

@kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Apr 15, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR introduces the getAllExtensions function to the IExtensionManager interface and updates related code to support dynamic contract routing based on available extensions.

Detailed summary

  • Added getAllExtensions function to IExtensionManager.json.
  • Updated publish.ts to conditionally set defaultExtensions and defaultModules.
  • Enhanced getRouterType to detect dynamic routing.
  • Implemented isGetAllExtensionsSupported and decodeGetAllExtensionsResult functions.
  • Created getAllExtensions function to call the new contract method.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team, jnsdls and joaquim-verges as code owners April 15, 2025 08:15
@vercel
Copy link

vercel bot commented Apr 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 8:30am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 8:30am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 8:30am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 8:30am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 8:30am

@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 23c2153

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 15, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 49.91 KB (0%) 999 ms (0%) 154 ms (+128.75% 🔺) 1.2 s
thirdweb (cjs) 136.37 KB (0%) 2.8 s (0%) 234 ms (+36.4% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.63 KB (0%) 113 ms (0%) 63 ms (+1092.58% 🔺) 175 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 49 ms (+2712.31% 🔺) 59 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 388 ms (0%) 70 ms (+500.46% 🔺) 457 ms

@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.76%. Comparing base (185d2f3) to head (23c2153).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../thirdweb/src/extensions/thirdweb/write/publish.ts 72.72% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (72.72%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6729      +/-   ##
==========================================
- Coverage   54.76%   54.76%   -0.01%     
==========================================
  Files         894      894              
  Lines       56201    56209       +8     
  Branches     3820     3825       +5     
==========================================
+ Hits        30780    30781       +1     
- Misses      25326    25333       +7     
  Partials       95       95
Flag Coverage Δ
packages 54.76% <72.72%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
.../thirdweb/src/extensions/thirdweb/write/publish.ts 90.81% <72.72%> (-1.41%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 4c1f384 into main Apr 15, 2025
22 of 23 checks passed
@joaquim-verges joaquim-verges deleted the yash/fix-dynamic-contract-publish branch April 15, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls jnsdls is a code owner

Assignees

@kumaryash90 kumaryash90

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaryash90 @joaquim-verges