Skip to content

[SDK] Refactor ERC721 getNFTs to handle token ID offsets correctly #6768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

[SDK] Refactor ERC721 getNFTs to handle token ID offsets correctly #6768

merged 1 commit into from
Apr 18, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 18, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on modifying the getNFTs functionality across the erc721 and erc1155 extensions to include a new parameter useIndexer, enhancing NFT retrieval processes and supply information handling.

Detailed summary

  • Added useIndexer: false in getOwnedNFTs for erc721 and erc1155.
  • Updated variable names for clarity (e.g., supply to supplyInfo).
  • Enhanced getNFTsFromRPC to calculate startTokenId and maxSupply.
  • Introduced getSupplyInfo function to encapsulate supply details retrieval.
  • Removed redundant promise handling in getNFTsFromRPC.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:23am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:23am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:23am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:23am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2025 9:23am

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 401aaa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review April 18, 2025 09:09
@joaquim-verges joaquim-verges requested review from a team as code owners April 18, 2025 09:09
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 18, 2025
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Apr 18, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges force-pushed the _SDK_Refactor_ERC721_getNFTs_to_handle_token_ID_offsets_correctly branch from 7a75e53 to 401aaa2 Compare April 18, 2025 09:11
@joaquim-verges joaquim-verges merged commit f38b262 into main Apr 18, 2025
17 of 19 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_Refactor_ERC721_getNFTs_to_handle_token_ID_offsets_correctly branch April 18, 2025 09:14
@codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.19%. Comparing base (5b35a62) to head (401aaa2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/thirdweb/src/extensions/erc721/read/getNFTs.ts 93.93% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6768      +/-   ##
==========================================
+ Coverage   55.17%   55.19%   +0.01%     
==========================================
  Files         896      896              
  Lines       56903    56921      +18     
  Branches     3940     3943       +3     
==========================================
+ Hits        31396    31416      +20     
+ Misses      25411    25409       -2     
  Partials       96       96
Flag Coverage Δ
packages 55.19% <94.59%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
...irdweb/src/extensions/erc1155/read/getOwnedNFTs.ts 65.15% <100.00%> (+1.08%) ⬆️
...hirdweb/src/extensions/erc721/read/getOwnedNFTs.ts 100.00% <100.00%> (ø)
...ges/thirdweb/src/extensions/erc721/read/getNFTs.ts 89.71% <93.93%> (-0.50%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.75 KB (0%) 1.1 s (0%) 222 ms (+105.12% 🔺) 1.3 s
thirdweb (cjs) 139.02 KB (0%) 2.8 s (0%) 351 ms (+45.8% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 78 ms (+812.15% 🔺) 190 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 38 ms (+869.39% 🔺) 49 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 122 ms (+505.78% 🔺) 509 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @jnsdls