Dashboard: Fix table row not clickable in safari because of sticky thead #6783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
github-actions
bot
added
Dashboard
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
added
the
hotfix
Graphite App
jnsdls
approved these changes
Apr 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6783 +/- ##
=======================================
Coverage 55.18% 55.18%
=======================================
Files 896 896
Lines 56924 56924
Branches 3943 3943
=======================================
Hits 31412 31412
Misses 25416 25416
Partials 96 96
🚀 New features to boost your workflow:
|
MananTank
removed
the
hotfix
Contributor
size-limit report 📦
|
Member
Author
Merge activity
|
MananTank
force-pushed
the
04-21-dashboard_fix_table_row_not_clickable_in_safari_because_of_sticky_thead
branch
from
8b2f298 to
cfbccf9
Compare
…ead (#6783) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `className` property of the `<thead>` component in two files to simplify its styling. ### Detailed summary - Updated `className` in `<thead>` component in `apps/dashboard/src/@/components/ui/table.tsx`: - Changed from a complex string with multiple classes to a simpler string: `"relative border-b bg-background"`. - Applied the same change in `apps/playground-web/src/components/ui/table.tsx`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
04-21-dashboard_fix_table_row_not_clickable_in_safari_because_of_sticky_thead
branch
from
cfbccf9 to
8937d55
Compare
graphite-app
bot
deleted the
04-21-dashboard_fix_table_row_not_clickable_in_safari_because_of_sticky_thead
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on updating the
classNameprop in thetheadcomponent of two files, simplifying the styling by removing unnecessary classes.Detailed summary
In
apps/dashboard/src/@/components/ui/table.tsx:className.relativeclass toclassName.In
apps/playground-web/src/components/ui/table.tsx:classNamesimilarly.