Skip to content

chore: Support Engine Core and Webhook usage events #6960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

chore: Support Engine Core and Webhook usage events #6960

merged 2 commits into from
May 6, 2025

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented May 6, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR enhances the @thirdweb-dev/service-utils package by adding support for Engine Core and Webhook usage events in the usageV2 module.

Detailed summary

  • Updated USAGE_V2_SOURCES to include engine-cloud and webhook.
  • Modified getTopicName function to handle engine-cloud and return usage_v2.raw_engine.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner May 6, 2025 15:00
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: 75dbd90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 3:01pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 3:01pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 3:01pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 3:01pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 3:01pm

@graphite-app
Copy link
Contributor

graphite-app bot commented May 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.01 KB (0%) 1.1 s (0%) 186 ms (+185.1% 🔺) 1.3 s
thirdweb (cjs) 143.13 KB (0%) 2.9 s (0%) 333 ms (+76.65% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 86 ms (+1570.37% 🔺) 199 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 34 ms (+2284.29% 🔺) 44 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 76 ms (+444.07% 🔺) 465 ms

@codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (9d40b13) to head (75dbd90).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6960   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         898      898           
  Lines       57342    57342           
  Branches     3967     3967           
=======================================
  Hits        31558    31558           
  Misses      25687    25687           
  Partials       97       97
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arcoraven arcoraven merged commit 928113b into main May 6, 2025
24 checks passed
@arcoraven arcoraven deleted the ph/new-usage-services branch May 6, 2025 23:02
@joaquim-verges joaquim-verges mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arcoraven arcoraven

Labels

packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arcoraven