[PayEmbed] Always connect to destination chain if available #6967
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ebf2840 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| chain={toChain || props.connectOptions?.chain} | ||
| chains={[toChain, ...(props.connectOptions?.chains || [])]} |
There was a problem hiding this comment.
The current change always prioritizes the destination chain (toChain) which is causing test failures. We should only use toChain when it's explicitly needed for the payment flow, and preserve the original chain configuration in test environments. Consider adding a condition to check if we're in a test environment or if the original chain should be preserved for certain operations.
Spotted by Diamond (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
size-limit report 📦
|
joaquim-verges
deleted the
_PayEmbed_Always_connect_to_destination_chain_if_available
branch
PR-Codex overview
This PR focuses on enhancing the
PayEmbedfunctionality by ensuring it always connects to the destination chain when available. It also refines the handling ofchainandchainsproperties in theBuyScreencomponent.Detailed summary
BuyScreen.tsxto always connect to the destination chain if available.chainassignment to usetoChainor fallback toprops.connectOptions?.chain.chainsto includetoChainand existing chains fromprops.connectOptions?.chains.