From e74574ccf5243430b9196263201dcfbb7e86b952 Mon Sep 17 00:00:00 2001 From: MananTank Date: Mon, 12 May 2025 20:54:35 +0000 Subject: [PATCH] [NEB-239] Fix chain search not working properly for chain name starting with number (#7023) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ## PR-Codex overview This PR focuses on improving the code by replacing `Number.parseInt` with `Number` for checking if a value is an integer across multiple files, enhancing readability and consistency. ### Detailed summary - In `TokenSelector.tsx`, changed `Number.parseInt(searchValue)` to `Number(searchValue)`. - In `single-network-selector.tsx`, modified the same integer check. - In `ConfigureCustomChain.tsx`, updated integer check for `chainSlug`. - In `NetworkSelectors.tsx`, replaced the integer check similarly. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` --- apps/dashboard/src/@/components/blocks/NetworkSelectors.tsx | 4 ++-- apps/dashboard/src/@/components/blocks/TokenSelector.tsx | 2 +- .../[contractAddress]/_layout/ConfigureCustomChain.tsx | 2 +- .../[contractAddress]/cross-chain/single-network-selector.tsx | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/apps/dashboard/src/@/components/blocks/NetworkSelectors.tsx b/apps/dashboard/src/@/components/blocks/NetworkSelectors.tsx index 48f52529847..a16b0b40548 100644 --- a/apps/dashboard/src/@/components/blocks/NetworkSelectors.tsx +++ b/apps/dashboard/src/@/components/blocks/NetworkSelectors.tsx @@ -71,7 +71,7 @@ export function MultiNetworkSelector(props: { return false; } - if (Number.isInteger(Number.parseInt(searchValue))) { + if (Number.isInteger(Number(searchValue))) { return String(chain.chainId).startsWith(searchValue); } return chain.name.toLowerCase().includes(searchValue.toLowerCase()); @@ -181,7 +181,7 @@ export function SingleNetworkSelector(props: { return false; } - if (Number.isInteger(Number.parseInt(searchValue))) { + if (Number.isInteger(Number(searchValue))) { return String(chain.chainId).startsWith(searchValue); } return chain.name.toLowerCase().includes(searchValue.toLowerCase()); diff --git a/apps/dashboard/src/@/components/blocks/TokenSelector.tsx b/apps/dashboard/src/@/components/blocks/TokenSelector.tsx index 6a03a576368..53e24896aca 100644 --- a/apps/dashboard/src/@/components/blocks/TokenSelector.tsx +++ b/apps/dashboard/src/@/components/blocks/TokenSelector.tsx @@ -46,7 +46,7 @@ export function TokenSelector(props: { return false; } - if (Number.isInteger(Number.parseInt(searchValue))) { + if (Number.isInteger(Number(searchValue))) { return String(token.chainId).startsWith(searchValue); } return ( diff --git a/apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/_layout/ConfigureCustomChain.tsx b/apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/_layout/ConfigureCustomChain.tsx index 5dc2114dfb2..56f8ca2bef7 100644 --- a/apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/_layout/ConfigureCustomChain.tsx +++ b/apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/_layout/ConfigureCustomChain.tsx @@ -11,7 +11,7 @@ export function ConfigureCustomChain(props: { chainSlug: string; }) { const { chainSlug } = props; - const isSlugNumber = Number.isInteger(Number.parseInt(chainSlug)); + const isSlugNumber = Number.isInteger(Number(chainSlug)); const [isConfigured, setIsConfigured] = useState(false); if (isConfigured) { diff --git a/apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/cross-chain/single-network-selector.tsx b/apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/cross-chain/single-network-selector.tsx index d87d8d2d22a..fd0f43faa88 100644 --- a/apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/cross-chain/single-network-selector.tsx +++ b/apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/cross-chain/single-network-selector.tsx @@ -29,7 +29,7 @@ export function SingleNetworkSelector(props: { return false; } - if (Number.isInteger(Number.parseInt(searchValue))) { + if (Number.isInteger(Number(searchValue))) { return String(chain.chainId).startsWith(searchValue); } return chain.name.toLowerCase().includes(searchValue.toLowerCase());