Skip to content

Conversation

@GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented May 14, 2025


PR-Codex overview

This PR introduces a new array of API links in the Header component and adds a dropdown for these links, enhancing navigation for users.

Detailed summary

  • Added a constant apisLinks containing three API link objects with name and href properties.
  • Introduced a new DropdownLinks component for apisLinks in the Header component.
  • Adjusted the padding class from xl:px-2 to xl:px-1 for the dropdown container.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@GiselleNessi GiselleNessi self-assigned this May 14, 2025
@GiselleNessi GiselleNessi requested review from a team as code owners May 14, 2025 14:15
@changeset-bot
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: ab74fcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 3:11pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) May 14, 2025 3:11pm
thirdweb_playground ⬜️ Skipped (Inspect) May 14, 2025 3:11pm
thirdweb-www ⬜️ Skipped (Inspect) May 14, 2025 3:11pm
wallet-ui ⬜️ Skipped (Inspect) May 14, 2025 3:11pm

@graphite-app
Copy link
Contributor

graphite-app bot commented May 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@GiselleNessi GiselleNessi requested a review from saminacodes May 14, 2025 14:15
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label May 14, 2025
@GiselleNessi GiselleNessi added the merge-queue Adds the pull request to Graphite's merge queue. label May 14, 2025
Copy link
Contributor Author

GiselleNessi commented May 14, 2025

Merge activity

@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.51%. Comparing base (1191d5d) to head (ab74fcd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7044   +/-   ##
=======================================
  Coverage   55.51%   55.51%           
=======================================
  Files         909      909           
  Lines       58402    58402           
  Branches     4071     4071           
=======================================
  Hits        32419    32419           
  Misses      25878    25878           
  Partials      105      105           
Flag Coverage Δ
packages 55.51% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 170 ms (+171.35% 🔺) 1.3 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 355 ms (+35.81% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 69 ms (+1015.44% 🔺) 183 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 24 ms (+919.77% 🔺) 34 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 78 ms (+380.22% 🔺) 468 ms

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR adds a new section to the `Header` component in the `Header.tsx` file, introducing `apisLinks` for API documentation links and integrating a `DropdownLinks` component for displaying these links.

### Detailed summary
- Added a new constant `apisLinks` containing links to API documentation.
- Introduced a `DropdownLinks` component to display `apisLinks` in the header.
- Adjusted padding in the header's layout from `xl:px-2` to `xl:px-1` for the new dropdown.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the gi/apis-nav-tab branch from cc121b2 to ab74fcd Compare May 14, 2025 15:09
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 14, 2025 15:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 15:09 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 15:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 15:09 Inactive
@graphite-app graphite-app bot merged commit ab74fcd into main May 14, 2025
22 checks passed
@graphite-app graphite-app bot deleted the gi/apis-nav-tab branch May 14, 2025 15:12
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label May 14, 2025
@vercel vercel bot temporarily deployed to Production – login May 14, 2025 15:12 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www May 14, 2025 15:12 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 14, 2025 15:12 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 14, 2025 15:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants