Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jul 14, 2025

Update Nebula Rate Limit Type

This PR updates the Nebula rate limit type to provide more granular control by replacing the single rateLimit number with an object containing perSecond and perMinute properties. The change affects:

  • The TeamCapabilities type in the service-utils package
  • Corresponding mock data and stubs in the dashboard app
  • Added a changeset to document this patch update

PR-Codex overview

This PR focuses on updating the rateLimit type for the nebula object in the service-utils package. It changes the rateLimit from a single number to an object that specifies limits per second and per minute.

Detailed summary

  • Updated rateLimit in packages/service-utils/src/mocks.ts from a number to an object with perSecond and perMinute.
  • Updated rateLimit in apps/dashboard/src/@/storybook/stubs.ts similarly.
  • Updated type definition in packages/service-utils/src/core/api.ts for rateLimit to reflect the new object structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 0:22am
nebula ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 0:22am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 0:22am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 0:22am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 0:22am

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2025

🦋 Changeset detected

Latest commit: f82f885

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Jul 14, 2025
@jnsdls jnsdls marked this pull request as ready for review July 14, 2025 23:13
@jnsdls jnsdls requested review from a team as code owners July 14, 2025 23:13
Copy link
Member Author

jnsdls commented Jul 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.44%. Comparing base (34d2fdd) to head (f82f885).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7614   +/-   ##
=======================================
  Coverage   56.44%   56.44%           
=======================================
  Files         906      906           
  Lines       58126    58126           
  Branches     4228     4228           
=======================================
  Hits        32811    32811           
  Misses      25205    25205           
  Partials      110      110           
Flag Coverage Δ
packages 56.44% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.25 KB (0%) 1.3 s (0%) 261 ms (+128.14% 🔺) 1.6 s
thirdweb (cjs) 353.31 KB (0%) 7.1 s (0%) 967 ms (+6.88% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 125 ms (+1706.22% 🔺) 239 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 57 ms (+2116.35% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 82 ms (+306.83% 🔺) 473 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 15, 2025

Merge activity

# Update Nebula Rate Limit Type

This PR updates the Nebula rate limit type to provide more granular control by replacing the single `rateLimit` number with an object containing `perSecond` and `perMinute` properties. The change affects:

- The `TeamCapabilities` type in the service-utils package
- Corresponding mock data and stubs in the dashboard app
- Added a changeset to document this patch update
@graphite-app graphite-app bot force-pushed the Update_error_response_URL_for_project_settings branch from 71efe7a to 34d2fdd Compare July 15, 2025 00:12
@graphite-app graphite-app bot force-pushed the Update_nebula_rateLimit_type_to_include_perSecond_and_perMinute branch from 9cfb3be to f82f885 Compare July 15, 2025 00:13
Base automatically changed from Update_error_response_URL_for_project_settings to main July 15, 2025 00:22
@graphite-app graphite-app bot merged commit f82f885 into main Jul 15, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants