[SDK] Add transaction hash to max wait time error #7789

joaquim-verges · 2025-08-04T23:21:50Z

PR-Codex overview

This PR focuses on improving error messages related to transaction receipt retrieval in the thirdweb package by including the transaction hash in the error messages.

Detailed summary

Updated the error message in wait-for-tx-receipt.ts to include the transactionHash.
Modified the test in wait-for-tx-receipt.test.ts to reflect the new error message format, incorporating MOCK_TX_HASH.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

New Features
- Error messages for transaction timeouts now include the transaction hash, improving traceability and context when a transaction exceeds the maximum wait time.

vercel · 2025-08-04T23:21:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 5, 2025 0:00am
nebula	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 5, 2025 0:00am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 5, 2025 0:00am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 5, 2025 0:00am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 5, 2025 0:00am

changeset-bot · 2025-08-04T23:21:53Z

🦋 Changeset detected

Latest commit: 658f38c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/nebula	Patch
@thirdweb-dev/wagmi-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-08-04T23:21:57Z

Walkthrough

A patch update was made to the "thirdweb" component to improve error reporting in transaction receipt polling. The error message for exceeding the maximum wait time now includes the transaction hash, providing more specific information for traceability when a transaction receipt is not found within the expected block range.

Changes

Cohort / File(s)	Change Summary
Error Message Enhancement `.changeset/odd-fans-tickle.md`, `packages/thirdweb/src/transaction/actions/wait-for-tx-receipt.ts`, `packages/thirdweb/src/transaction/actions/wait-for-tx-receipt.test.ts`	Updated the error message for transaction receipt polling timeouts to include the transaction hash; test assertions updated accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2468c17 and 658f38c.

📒 Files selected for processing (3)

.changeset/odd-fans-tickle.md (1 hunks)
packages/thirdweb/src/transaction/actions/wait-for-tx-receipt.test.ts (1 hunks)
packages/thirdweb/src/transaction/actions/wait-for-tx-receipt.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

packages/thirdweb/src/transaction/actions/wait-for-tx-receipt.test.ts

🚧 Files skipped from review as they are similar to previous changes (2)

.changeset/odd-fans-tickle.md
packages/thirdweb/src/transaction/actions/wait-for-tx-receipt.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: Unit Tests
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Size
GitHub Check: Build Packages
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: Lint Packages
GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch Add_transaction_hash_to_max_wait_time_error

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

joaquim-verges · 2025-08-04T23:22:12Z

[SDK] Add transaction hash to max wait time error #7789 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-08-04T23:27:37Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	63.16 KB (+0.02% 🔺)	1.3 s (+0.02% 🔺)	196 ms (+127.89% 🔺)	1.5 s
thirdweb (cjs)	352.95 KB (-0.02% 🔽)	7.1 s (-0.02% 🔽)	655 ms (+11.49% 🔺)	7.8 s
thirdweb (minimal + tree-shaking)	5.7 KB (0%)	114 ms (0%)	98 ms (+1846.62% 🔺)	212 ms
thirdweb/chains (tree-shaking)	526 B (0%)	11 ms (0%)	21 ms (+1275.23% 🔺)	31 ms
thirdweb/react (minimal + tree-shaking)	19.26 KB (-0.21% 🔽)	386 ms (-0.21% 🔽)	97 ms (+740.4% 🔺)	482 ms

codecov · 2025-08-04T23:53:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.34%. Comparing base (ad2d225) to head (658f38c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7789      +/-   ##
==========================================
- Coverage   56.34%   56.34%   -0.01%     
==========================================
  Files         905      905              
  Lines       58788    58788              
  Branches     4142     4141       -1     
==========================================
- Hits        33127    33122       -5     
- Misses      25556    25561       +5     
  Partials      105      105

Flag	Coverage Δ
packages	`56.34% <100.00%> (-0.01%)`	⬇️

Files with missing lines	Coverage Δ
...web/src/transaction/actions/wait-for-tx-receipt.ts	`91.07% <100.00%> (-3.58%)`	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions bot assigned joaquim-verges Aug 4, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Aug 4, 2025

vercel bot deployed to Preview – nebula August 4, 2025 23:24 View deployment

joaquim-verges changed the title ~~Add transaction hash to max wait time error~~ [SDK] Add transaction hash to max wait time error Aug 4, 2025

joaquim-verges marked this pull request as ready for review August 4, 2025 23:25

joaquim-verges requested review from a team as code owners August 4, 2025 23:25

vercel bot deployed to Preview – wallet-ui August 4, 2025 23:31 View deployment

vercel bot deployed to Preview – thirdweb-www August 4, 2025 23:31 View deployment

vercel bot deployed to Preview – thirdweb_playground August 4, 2025 23:33 View deployment

vercel bot deployed to Preview – docs-v2 August 4, 2025 23:42 View deployment

Add transaction hash to max wait time error

658f38c

joaquim-verges force-pushed the Add_transaction_hash_to_max_wait_time_error branch from 2468c17 to 658f38c Compare August 4, 2025 23:47

vercel bot deployed to Preview – nebula August 4, 2025 23:50 View deployment

vercel bot deployed to Preview – thirdweb-www August 4, 2025 23:55 View deployment

vercel bot deployed to Preview – docs-v2 August 4, 2025 23:56 View deployment

vercel bot deployed to Preview – thirdweb_playground August 4, 2025 23:59 View deployment

vercel bot deployed to Preview – wallet-ui August 5, 2025 00:00 View deployment

joaquim-verges merged commit 9a3ebe1 into main Aug 5, 2025
25 checks passed

joaquim-verges deleted the Add_transaction_hash_to_max_wait_time_error branch August 5, 2025 00:17

joaquim-verges mentioned this pull request Aug 2, 2025

Version Packages #7776

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Add transaction hash to max wait time error #7789

[SDK] Add transaction hash to max wait time error #7789

Uh oh!

joaquim-verges commented Aug 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

joaquim-verges commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[SDK] Add transaction hash to max wait time error #7789

[SDK] Add transaction hash to max wait time error #7789

Uh oh!

Conversation

joaquim-verges commented Aug 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

vercel bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

joaquim-verges commented Aug 4, 2025

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joaquim-verges commented Aug 4, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Aug 4, 2025 •

edited

Loading

changeset-bot bot commented Aug 4, 2025 •

edited

Loading

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Aug 4, 2025 •

edited

Loading

codecov bot commented Aug 4, 2025 •

edited

Loading