Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Aug 6, 2025


PR-Codex overview

This PR enhances the AdvancedSearchInput component by adding a clear button, improving the layout, and introducing a loading spinner. It also modifies the InAppWalletUsersPageContent component to include tooltips and adjust the display of user identifiers and dates.

Detailed summary

  • Added XIcon to AdvancedSearchInput for a clear button.
  • Introduced a Spinner component for loading states.
  • Updated layout to improve responsiveness in AdvancedSearchInput.
  • Added ToolTipLabel for date display in InAppWalletUsersPageContent.
  • Enhanced user identifier display with a CopyTextButton.
  • Adjusted text sizes for better readability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Added an inline clear button ("X" icon) to the search input, allowing users to clear queries directly.
    • User identifiers now feature a copy-to-clipboard button with truncation and tooltip support.
    • Wallet creation dates now display detailed timestamps in a tooltip on hover.
  • Improvements

    • Enhanced responsive layout for search input and controls, optimizing usability across devices.
    • Updated button styles and input appearance for a more cohesive look.
    • CSV export now uses ISO date format for wallet creation dates.
    • Improved font size and styling for wallet labels and download button.

@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2025

⚠️ No Changeset found

Latest commit: 56b12c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 6, 2025

Walkthrough

The changes update the in-app wallet users UI components to improve layout responsiveness, search and clear functionality, identifier display, and tooltip usage. The search input and controls are restyled, a clear button is added, identifier cells use a copy-to-clipboard button, tooltips are added to dates, and CSV export formatting is updated.

Changes

Cohort / File(s) Change Summary
Advanced Search Input UI & Functionality
apps/dashboard/src/@/components/in-app-wallet-users-content/AdvancedSearchInput.tsx
Refactored layout to horizontal flex on medium screens, updated search input styling, added inline clear ("X") button visible with results, restyled search button with spinner, removed separate clear button, and updated imports for new icons.
Wallet Users Content Table & Export
apps/dashboard/src/@/components/in-app-wallet-users-content/in-app-wallet-users-content.tsx
Replaced identifier text with copy-to-clipboard button, updated "None" label style, wrapped creation date in tooltip with detailed timestamp, changed CSV date export to ISO format, and improved responsive layout and styling for top section and download button.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AdvancedSearchInput
    participant WalletUsersContent

    User->>AdvancedSearchInput: Types search query
    AdvancedSearchInput->>WalletUsersContent: Triggers search with query
    User->>AdvancedSearchInput: Clicks clear "X" button
    AdvancedSearchInput->>WalletUsersContent: Clears search results

    User->>WalletUsersContent: Views identifier cell
    WalletUsersContent->>User: Shows CopyTextButton (truncated if long)
    User->>WalletUsersContent: Hovers over creation date
    WalletUsersContent->>User: Shows tooltip with detailed timestamp

    User->>WalletUsersContent: Clicks Download CSV
    WalletUsersContent->>User: Downloads CSV with ISO date format
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b686bb and 56b12c6.

📒 Files selected for processing (2)
  • apps/dashboard/src/@/components/in-app-wallet-users-content/AdvancedSearchInput.tsx (2 hunks)
  • apps/dashboard/src/@/components/in-app-wallet-users-content/in-app-wallet-users-content.tsx (8 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/dashboard/src/@/components/in-app-wallet-users-content/AdvancedSearchInput.tsx
  • apps/dashboard/src/@/components/in-app-wallet-users-content/in-app-wallet-users-content.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Build Packages
  • GitHub Check: Lint Packages
  • GitHub Check: Unit Tests
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 08-06-dashboard_export_the_csv_date_as_iso_string_in_wallets_users_table_ui_tweaks

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Aug 6, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review August 6, 2025 17:12
@MananTank MananTank requested review from a team as code owners August 6, 2025 17:12
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 6, 2025 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 6, 2025 17:13 Inactive
@vercel
Copy link

vercel bot commented Aug 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2025 5:35pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Aug 6, 2025 5:35pm
nebula ⬜️ Skipped (Inspect) Aug 6, 2025 5:35pm
thirdweb_playground ⬜️ Skipped (Inspect) Aug 6, 2025 5:35pm
wallet-ui ⬜️ Skipped (Inspect) Aug 6, 2025 5:35pm

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.34%. Comparing base (abbdb0f) to head (56b12c6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7802   +/-   ##
=======================================
  Coverage   56.34%   56.34%           
=======================================
  Files         905      905           
  Lines       58788    58788           
  Branches     4141     4141           
=======================================
  Hits        33122    33122           
  Misses      25561    25561           
  Partials      105      105           
Flag Coverage Δ
packages 56.34% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – docs-v2 August 6, 2025 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula August 6, 2025 17:13 Inactive
@MananTank MananTank force-pushed the 08-06-dashboard_export_the_csv_date_as_iso_string_in_wallets_users_table_ui_tweaks branch from 94df0c7 to 2b686bb Compare August 6, 2025 17:13
@vercel vercel bot temporarily deployed to Preview – nebula August 6, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 6, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 6, 2025 17:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 August 6, 2025 17:14 Inactive
@MananTank MananTank changed the title Dashboard: export the CSV date as ISO string in Wallets/users table, UI tweaks Dashboard: export the date in CSV as ISO string in Wallets/users table, UI tweaks Aug 6, 2025
@MananTank MananTank changed the title Dashboard: export the date in CSV as ISO string in Wallets/users table, UI tweaks Dashboard: export the date in CSV as ISO string in wallets/users table, UI tweaks Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.16 KB (0%) 1.3 s (0%) 145 ms (+252.18% 🔺) 1.5 s
thirdweb (cjs) 352.95 KB (0%) 7.1 s (0%) 375 ms (+22.46% 🔺) 7.5 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 45 ms (+1922.68% 🔺) 159 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 29 ms (+1282.7% 🔺) 40 ms
thirdweb/react (minimal + tree-shaking) 19.26 KB (0%) 386 ms (0%) 48 ms (+636.35% 🔺) 433 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 6, 2025

Merge activity

…e, UI tweaks (#7802)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `AdvancedSearchInput` component by adding a clear button, improving the layout, and integrating a loading spinner. It also updates the `InAppWalletUsersPageContent` to include a tooltip for user identifiers and modifies the display of created dates.

### Detailed summary
- Added `XIcon` to `AdvancedSearchInput` for a clear button.
- Integrated `Spinner` for loading state in `AdvancedSearchInput`.
- Improved layout with responsive design adjustments.
- Added `ToolTipLabel` for user identifier display in `InAppWalletUsersPageContent`.
- Changed date format to ISO in `InAppWalletUsersPageContent`.
- Updated button styles for better UI consistency.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **New Features**
  * Added an inline clear button ("X" icon) to the search input, allowing users to clear queries directly.
  * User identifiers now feature a copy-to-clipboard button with truncation and tooltip support.
  * Wallet creation dates now display detailed timestamps in a tooltip on hover.

* **Improvements**
  * Enhanced responsive layout for search input and controls, optimizing usability across devices.
  * Updated button styles and input appearance for a more cohesive look.
  * CSV export now uses ISO date format for wallet creation dates.
  * Improved font size and styling for wallet labels and download button.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 08-06-dashboard_export_the_csv_date_as_iso_string_in_wallets_users_table_ui_tweaks branch from 2b686bb to 56b12c6 Compare August 6, 2025 17:27
@vercel vercel bot temporarily deployed to Preview – docs-v2 August 6, 2025 17:27 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula August 6, 2025 17:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 6, 2025 17:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 6, 2025 17:27 Inactive
@graphite-app graphite-app bot merged commit 56b12c6 into main Aug 6, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-06-dashboard_export_the_csv_date_as_iso_string_in_wallets_users_table_ui_tweaks branch August 6, 2025 17:36
@vercel vercel bot temporarily deployed to Production – nebula August 6, 2025 17:36 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 August 6, 2025 17:36 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui August 6, 2025 17:36 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground August 6, 2025 17:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants