-
Notifications
You must be signed in to change notification settings - Fork 619
Version Packages #7810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7810
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis change updates the version numbers and changelogs for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/wagmi-adapter/package.json (1)
58-58: Version bump OK – consider widening the documentedthirdwebpeer range
^5.85.0already includes5.105.x, but consumers browsingpackage.jsonmight not realise this adapter was validated against the latest SDK. Bumping to^5.105.0(or^5.100.0) would signal explicit compatibility while still protecting against the next major.packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Populate the 0.2.126 entry with at least one bullet
Blank sections hinder traceability. Suggest adding something like:## 0.2.126 +### Patch Changes +- Bumped internal/peer dependency `thirdweb` to `5.105.29` (fixes envs without global `process`). No code changes.Keeps the changelog informative for downstream users.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/chilly-lamps-post.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/chilly-lamps-post.md
🧰 Additional context used
📓 Path-based instructions (1)
packages/wagmi-adapter/**
📄 CodeRabbit Inference Engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
🧠 Learnings (8)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
📚 Learning: applies to packages/thirdweb/src/exports/** : export everything via `exports/` directory, grouped by...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Export everything via `exports/` directory, grouped by feature in the SDK public API
Applied to files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/CHANGELOG.mdpackages/thirdweb/package.json
📚 Learning: in the thirdweb/js project, the react namespace is available for type annotations (like react.fc) wi...
Learnt from: MananTank
PR: thirdweb-dev/js#7356
File: apps/nebula/src/app/not-found.tsx:1-1
Timestamp: 2025-06-17T18:30:52.976Z
Learning: In the thirdweb/js project, the React namespace is available for type annotations (like React.FC) without needing to explicitly import React. This is project-specific configuration that differs from typical TypeScript/React setups.
Applied to files:
packages/nebula/package.jsonpackages/thirdweb/package.json
📚 Learning: applies to packages/thirdweb/src/exports/** : every public symbol must have comprehensive tsdoc with...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/exports/** : Every public symbol must have comprehensive TSDoc with at least one `example` block that compiles and custom annotation tags (`beta`, `internal`, `experimental`)
Applied to files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.json
📚 Learning: applies to packages/wagmi-adapter/** : wagmi ecosystem integration is in `packages/wagmi-adapter/`...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
📚 Learning: applies to packages/react-native-adapter/** : mobile platform shims are in `packages/react-native-ad...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/react-native-adapter/** : Mobile platform shims are in `packages/react-native-adapter/`
Applied to files:
packages/wagmi-adapter/package.json
📚 Learning: surface breaking changes prominently in pr descriptions...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Surface breaking changes prominently in PR descriptions
Applied to files:
packages/thirdweb/CHANGELOG.mdpackages/thirdweb/package.jsonpackages/nebula/CHANGELOG.md
📚 Learning: applies to src/exports/react.native.ts : react native specific exports are in `src/exports/react.nat...
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to src/exports/react.native.ts : React Native specific exports are in `src/exports/react.native.ts`
Applied to files:
packages/thirdweb/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/thirdweb/package.json (1)
412-412: Confirm ancillary release artefacts are in syncPackage version bump itself looks correct.
Please double-check that the accompanying CHANGELOG entry, git tag, and any release automation configs (Changesets, CI publish step) all reference5.105.29, otherwise the publish may be skipped or mis-tagged.packages/thirdweb/CHANGELOG.md (1)
3-8: Changelog entry LGTMVersion bump and patch notes follow semver and house style; no further action required.
packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry looks complete and consistent.The version heading, patch section, and dependency bullet correctly describe the bump to
[email protected]and reference the commit. No further edits required.packages/nebula/package.json (1)
60-60: Version bump aligns with the changelog.
"version": "0.2.29"matches the new changelog entry and follows semver patch-level expectations. LGTM.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7810 +/- ##
=======================================
Coverage 56.33% 56.33%
=======================================
Files 905 905
Lines 58809 58809
Branches 4143 4147 +4
=======================================
Hits 33131 33131
Misses 25573 25573
Partials 105 105
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
c0948fb]:[email protected]
Patch Changes
c0948fbThanks @joaquim-verges! - Handle environments where process is not defined@thirdweb-dev/[email protected]
PR-Codex overview
This PR primarily focuses on updating version numbers in several
package.jsonfiles and adding new entries to theCHANGELOG.mdfiles forthirdweb,nebula, andwagmi-adapter. It also includes dependency updates.Detailed summary
.changeset/chilly-lamps-post.md.versioninpackages/thirdweb/package.jsonfrom5.105.28to5.105.29.versioninpackages/nebula/package.jsonfrom0.2.28to0.2.29.versioninpackages/wagmi-adapter/package.jsonfrom0.2.125to0.2.126.## 0.2.29and patch notes inpackages/nebula/CHANGELOG.md.## 5.105.29and patch notes inpackages/thirdweb/CHANGELOG.md.Summary by CodeRabbit
Bug Fixes
Chores