fparser on MSVC.

[dsa-t]

To build this project on MSVC I've had to apply this patch to fparser:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index a9b7868..5e97475 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -23,7 +23,7 @@ set(SOURCES fparser.cc fpoptimizer.cc)
 
 remove(CMAKE_CXX_FLAGS -Dfparser_EXPORTS)
 
-ADD_LIBRARY(fparser SHARED ${SOURCES})
+ADD_LIBRARY(fparser STATIC ${SOURCES})
 
 set_target_properties(fparser PROPERTIES VERSION ${LIB_VERSION_STRING} SOVERSION ${LIB_VERSION_MAJOR})
 

Then in ExternalProject_Add( CSXCAD -> CMAKE_ARGS
add:
-Dfparser_LIBRARIES=${CMAKE_INSTALL_PREFIX}/lib/fparser.lib

When I was specifying -Dfparser_LIBRARIES=${CMAKE_INSTALL_PREFIX}/lib/fparser.dll, there was an error:
fatal error LNK1107: invalid or corrupt file: cannot read at 0x360

Is there a reason for fparser to be shared?
Is there a reason why MSVC gives this error when using the .dll?

Also CSXCAD/CMakeLists.txt specifies NO_CMAKE_FIND_ROOT_PATH for fparser's find_library, so -Dfparser_LIBRARIES= must be specified.

Is there a reason for that instead of using the cmake find path?

[thliebig]

So far I had no issues with fparser and MSVC I think. But Windows and MSVC are just a fractal PITA.

I have not tries to build on Windows in a long while. I guess I have to get into that hell soon again...

[dsa-t]

After modifying fparser like this (and other changes to other things):

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5e97475..9035aa0 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -18,6 +18,8 @@ if(APPLE AND NOT CMAKE_INSTALL_NAME_DIR)
   set(CMAKE_INSTALL_NAME_DIR "${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX}")
 endif()
 
+set(CMAKE_POSITION_INDEPENDENT_CODE ON)
+
 #set(HEADERS fparser.hh fpconfig.hh fptypes.hh)
 set(SOURCES fparser.cc fpoptimizer.cc)

, it builds on Ubuntu/macOS/MSVC without using package managers: see https://github.com/dsa-t/openEMS-Project/actions/runs/13481863830