fixup! webhook: generate webhook using operator-sdk but without defaulting/mutating

thom311 · thom311 · commit 1102417e475d · 2025-02-25T13:30:13.000+01:00
diff --git a/api/v1/dpuoperatorconfig_webhook.go b/api/v1/dpuoperatorconfig_webhook.go
@@ -20,6 +20,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	ctrl "sigs.k8s.io/controller-runtime"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
+	//"sigs.k8s.io/controller-runtime/pkg/webhook"
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
 )
 
@@ -40,6 +41,7 @@ func (r *DpuOperatorConfig) SetupWebhookWithManager(mgr ctrl.Manager) error {
 // Modifying the path for an invalid path can cause API server errors; failing to locate the webhook.
 //+kubebuilder:webhook:path=/validate-config-openshift-io-v1-dpuoperatorconfig,mutating=false,failurePolicy=fail,sideEffects=None,groups=config.openshift.io,resources=dpuoperatorconfigs,verbs=create;update,versions=v1,name=vdpuoperatorconfig.kb.io,admissionReviewVersions=v1
 
+//var _ webhook.Validator = &DpuOperatorConfig{}
 
 // ValidateCreate implements webhook.Validator so a webhook will be registered for the type
 func (r *DpuOperatorConfig) ValidateCreate() (admission.Warnings, error) {
diff --git a/bundle/manifests/dpu-operator.clusterserviceversion.yaml b/bundle/manifests/dpu-operator.clusterserviceversion.yaml
@@ -38,7 +38,7 @@ metadata:
         }
       ]
     capabilities: Basic Install
-    createdAt: "2025-02-25T11:27:28Z"
+    createdAt: "2025-02-25T12:29:34Z"
     features.operators.openshift.io/cnf: "false"
     features.operators.openshift.io/cni: "true"
     features.operators.openshift.io/csi: "false"
diff --git a/manifests/stable/dpu-operator.clusterserviceversion.yaml b/manifests/stable/dpu-operator.clusterserviceversion.yaml
@@ -38,7 +38,7 @@ metadata:
         }
       ]
     capabilities: Basic Install
-    createdAt: "2025-02-25T11:27:28Z"
+    createdAt: "2025-02-25T12:29:34Z"
     features.operators.openshift.io/cnf: "false"
     features.operators.openshift.io/cni: "true"
     features.operators.openshift.io/csi: "false"
diff --git a/vendor/github.com/openshift/dpu-operator/api/v1/dpuoperatorconfig_webhook.go b/vendor/github.com/openshift/dpu-operator/api/v1/dpuoperatorconfig_webhook.go

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ metadata:`
`38`	`38`	`}`
`39`	`39`	`]`
`40`	`40`	`capabilities: Basic Install`
`41`		`- createdAt: "2025-02-25T11:27:28Z"`
	`41`	`+ createdAt: "2025-02-25T12:29:34Z"`
`42`	`42`	`features.operators.openshift.io/cnf: "false"`
`43`	`43`	`features.operators.openshift.io/cni: "true"`
`44`	`44`	`features.operators.openshift.io/csi: "false"`