webhook: generate webhook using operator-sdk but without defaulting/mutating

For now, we only need a validating and not a mutating webhook.

The parent commit generated both a validating and a mutating commit.
This commit on top of that and undoes the parts that are about enabling
the mutating webhook.

It's done this way, so we first generate both kinds of webhooks, and
then undo part of it. The benefit is that if we ever want to add the
mutating webhook, we can git-revert this commit. We also clearer see the
difference by doing it this way.

This commit has no manual changes, it is fully generated by running
the following command on the grandparent commit.

  $ make operator-sdk && \
    ./bin/operator-sdk create webhook --group config --version v1 --kind DpuOperatorConfig --programmatic-validation && \
    make vendor && \
    make manifests && \
    (cd api/ && go get github.com/onsi/ginkgo/[email protected]) && \
    make vendor && \
    make manifests && \
    make generate && \
    sed -i $'33i \\\tconfigv1 "github.com/openshift/dpu-operator/api/v1"' cmd/main.go && \
    sed -i 's/^- path: patches\/webhook_in_dpuoperatorconfigs.yaml/#\0/' config/crd/kustomization.yaml && \
    sed -i -e 's/var _ webhook.\(Defaulter\|Validator\)/\/\/\0/' \
        -e 's/"sigs.k8s.io\/controller-runtime\/pkg\/webhook"/\/\/\0/' \
        api/v1/dpuoperatorconfig_webhook.go \
        vendor/github.com/openshift/dpu-operator/api/v1/dpuoperatorconfig_webhook.go && \
    make bundle

Author: thom311

PROJECT

@@ -21,7 +21,6 @@ resources:
   path: github.com/openshift/dpu-operator/api/v1
   version: v1
   webhooks:
-    defaulting: true
     validation: true
     webhookVersion: v1
 - api:

api/v1/dpuoperatorconfig_webhook.go

@@ -36,17 +36,6 @@ func (r *DpuOperatorConfig) SetupWebhookWithManager(mgr ctrl.Manager) error {
 
 // TODO(user): EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!
 
-//+kubebuilder:webhook:path=/mutate-config-openshift-io-v1-dpuoperatorconfig,mutating=true,failurePolicy=fail,sideEffects=None,groups=config.openshift.io,resources=dpuoperatorconfigs,verbs=create;update,versions=v1,name=mdpuoperatorconfig.kb.io,admissionReviewVersions=v1
-
-//var _ webhook.Defaulter = &DpuOperatorConfig{}
-
-// Default implements webhook.Defaulter so a webhook will be registered for the type
-func (r *DpuOperatorConfig) Default() {
-	dpuoperatorconfiglog.Info("default", "name", r.Name)
-
-	// TODO(user): fill in your defaulting logic.
-}
-
 // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation.
 // NOTE: The 'path' attribute must follow a specific pattern and should not be modified directly here.
 // Modifying the path for an invalid path can cause API server errors; failing to locate the webhook.

api/v1/dpuoperatorconfig_webhook_test.go

@@ -22,14 +22,6 @@ import (
 
 var _ = Describe("DpuOperatorConfig Webhook", func() {
 
-	Context("When creating DpuOperatorConfig under Defaulting Webhook", func() {
-		It("Should fill in the default value if a required field is empty", func() {
-
-			// TODO(user): Add your logic here
-
-		})
-	})
-
 	Context("When creating DpuOperatorConfig under Validating Webhook", func() {
 		It("Should deny if a required field is empty", func() {
 

bundle/manifests/dpu-operator.clusterserviceversion.yaml

@@ -38,7 +38,7 @@ metadata:
         }
       ]
     capabilities: Basic Install
-    createdAt: "2025-02-25T12:19:48Z"
+    createdAt: "2025-02-25T12:29:34Z"
     features.operators.openshift.io/cnf: "false"
     features.operators.openshift.io/cni: "true"
     features.operators.openshift.io/csi: "false"
@@ -417,26 +417,6 @@ spec:
     url: www.redhat.com
   version: 4.19.0
   webhookdefinitions:
-  - admissionReviewVersions:
-    - v1
-    containerPort: 443
-    deploymentName: dpu-operator-controller-manager
-    failurePolicy: Fail
-    generateName: mdpuoperatorconfig.kb.io
-    rules:
-    - apiGroups:
-      - config.openshift.io
-      apiVersions:
-      - v1
-      operations:
-      - CREATE
-      - UPDATE
-      resources:
-      - dpuoperatorconfigs
-    sideEffects: None
-    targetPort: 9443
-    type: MutatingAdmissionWebhook
-    webhookPath: /mutate-config-openshift-io-v1-dpuoperatorconfig
   - admissionReviewVersions:
     - v1
     containerPort: 443

config/webhook/manifests.yaml

@@ -1,31 +1,5 @@
 ---
 apiVersion: admissionregistration.k8s.io/v1
-kind: MutatingWebhookConfiguration
-metadata:
-  name: mutating-webhook-configuration
-webhooks:
-- admissionReviewVersions:
-  - v1
-  clientConfig:
-    service:
-      name: webhook-service
-      namespace: system
-      path: /mutate-config-openshift-io-v1-dpuoperatorconfig
-  failurePolicy: Fail
-  name: mdpuoperatorconfig.kb.io
-  rules:
-  - apiGroups:
-    - config.openshift.io
-    apiVersions:
-    - v1
-    operations:
-    - CREATE
-    - UPDATE
-    resources:
-    - dpuoperatorconfigs
-  sideEffects: None
----
-apiVersion: admissionregistration.k8s.io/v1
 kind: ValidatingWebhookConfiguration
 metadata:
   name: validating-webhook-configuration

manifests/stable/dpu-operator.clusterserviceversion.yaml

@@ -38,7 +38,7 @@ metadata:
         }
       ]
     capabilities: Basic Install
-    createdAt: "2025-02-25T12:19:48Z"
+    createdAt: "2025-02-25T12:29:34Z"
     features.operators.openshift.io/cnf: "false"
     features.operators.openshift.io/cni: "true"
     features.operators.openshift.io/csi: "false"
@@ -417,26 +417,6 @@ spec:
     url: www.redhat.com
   version: 4.19.0
   webhookdefinitions:
-  - admissionReviewVersions:
-    - v1
-    containerPort: 443
-    deploymentName: dpu-operator-controller-manager
-    failurePolicy: Fail
-    generateName: mdpuoperatorconfig.kb.io
-    rules:
-    - apiGroups:
-      - config.openshift.io
-      apiVersions:
-      - v1
-      operations:
-      - CREATE
-      - UPDATE
-      resources:
-      - dpuoperatorconfigs
-    sideEffects: None
-    targetPort: 9443
-    type: MutatingAdmissionWebhook
-    webhookPath: /mutate-config-openshift-io-v1-dpuoperatorconfig
   - admissionReviewVersions:
     - v1
     containerPort: 443