chore: removed some compiler warnings

thomasduft · thomasduft · commit c256aac52f34 · 2025-08-24T09:24:51.000Z
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
@@ -10,14 +10,14 @@
       "rollForward": false
     },
     "dotnet-outdated-tool": {
-      "version": "4.6.7",
+      "version": "4.6.8",
       "commands": [
         "dotnet-outdated"
       ],
       "rollForward": false
     },
     "dotnet-ef": {
-      "version": "9.0.2",
+      "version": "9.0.8",
       "commands": [
         "dotnet-ef"
       ],
diff --git a/changelogs/9d1b3a327eb44f00afc5bca2ba25f9d6.cle b/changelogs/9d1b3a327eb44f00afc5bca2ba25f9d6.cle
@@ -0,0 +1,9 @@
+{
+  "Id": "9d1b3a32-7eb4-4f00-afc5-bca2ba25f9d6",
+  "IssueId": "",
+  "Prefix": "Added",
+  "Tag": "",
+  "Message": "Addes support for ClientCredentials flow in sample server.",
+  "CreatedAt": "2025-08-24T09:15:29.6713415+00:00",
+  "CreatedBy": "thomasduft"
+}
diff --git a/src/identity/OpenIddict.UI.Identity.Api/Account/AccountApiService.cs b/src/identity/OpenIddict.UI.Identity.Api/Account/AccountApiService.cs
@@ -76,14 +76,14 @@ public async Task<UserViewModel> GetUserAsync(string id)
       Email = user.Email,
       LockoutEnabled = user.LockoutEnabled,
       IsLockedOut = user.IsLockedOut,
-      Claims = new List<ClaimViewModel>(user.Claims.Select(x =>
+      Claims = [.. user.Claims.Select(x =>
       {
         return new ClaimViewModel
         {
           Type = x.Type,
           Value = x.Value
         };
-      })),
+      })],
       Roles = user.Roles
     };
   }
@@ -98,14 +98,14 @@ public async Task<IdentityResult> UpdateAsync(UserViewModel model)
     }
 
     var param = SimpleMapper.From<UserViewModel, UserParam>(model);
-    param.Claims = new List<ClaimInfo>(model.Claims.Select(c =>
+    param.Claims = [.. model.Claims.Select(c =>
     {
       return new ClaimInfo
       {
         Type = c.Type,
         Value = c.Value
       };
-    }));
+    })];
 
     return await _accountService.UpdateAsync(param);
   }
diff --git a/src/identity/OpenIddict.UI.Identity.Core/Interfaces/IAccountService.cs b/src/identity/OpenIddict.UI.Identity.Core/Interfaces/IAccountService.cs
@@ -6,10 +6,10 @@ namespace tomware.OpenIddict.UI.Identity.Core;
 
 public interface IAccountService
 {
-  Task<IdentityResult> RegisterAsync(RegisterUserParam model);
-  Task<IdentityResult> ChangePasswordAsync(ChangePasswordParam model);
-  Task<IEnumerable<UserInfo>> GetUsersAsync();
-  Task<UserInfo> GetUserAsync(string id);
-  Task<IdentityResult> UpdateAsync(UserParam model);
-  Task<IdentityResult> DeleteAsync(string id);
+  public Task<IdentityResult> RegisterAsync(RegisterUserParam model);
+  public Task<IdentityResult> ChangePasswordAsync(ChangePasswordParam model);
+  public Task<IEnumerable<UserInfo>> GetUsersAsync();
+  public Task<UserInfo> GetUserAsync(string id);
+  public Task<IdentityResult> UpdateAsync(UserParam model);
+  public Task<IdentityResult> DeleteAsync(string id);
 }
diff --git a/src/identity/OpenIddict.UI.Identity.Core/Interfaces/IClaimTypeService.cs b/src/identity/OpenIddict.UI.Identity.Core/Interfaces/IClaimTypeService.cs
@@ -6,13 +6,13 @@ namespace tomware.OpenIddict.UI.Identity.Core;
 
 public interface IClaimTypeService
 {
-  Task<IEnumerable<ClaimTypeInfo>> GetClaimTypesAsync();
+  public Task<IEnumerable<ClaimTypeInfo>> GetClaimTypesAsync();
 
-  Task<ClaimTypeInfo> GetAsync(Guid id);
+  public Task<ClaimTypeInfo> GetAsync(Guid id);
 
-  Task<Guid> CreateAsync(ClaimTypeParam model);
+  public Task<Guid> CreateAsync(ClaimTypeParam model);
 
-  Task UpdateAsync(ClaimTypeParam model);
+  public Task UpdateAsync(ClaimTypeParam model);
 
-  Task DeleteAsync(Guid id);
+  public Task DeleteAsync(Guid id);
 }
diff --git a/src/identity/OpenIddict.UI.Identity.Core/Interfaces/IUserCreationService.cs b/src/identity/OpenIddict.UI.Identity.Core/Interfaces/IUserCreationService.cs
@@ -7,5 +7,5 @@ public interface IUserCreationStrategy<TIdentityUser, TKey>
   where TKey : IEquatable<TKey>
   where TIdentityUser : IdentityUser<TKey>
 {
-  TIdentityUser CreateUser(RegisterUserParam model);
+  public TIdentityUser CreateUser(RegisterUserParam model);
 }
diff --git a/src/identity/OpenIddict.UI.Identity.Infrastructure/Data/OpenIddictUIIdentityContext.cs b/src/identity/OpenIddict.UI.Identity.Infrastructure/Data/OpenIddictUIIdentityContext.cs
@@ -12,7 +12,7 @@ public class OpenIddictUIIdentityStoreOptions
 
 public interface IOpenIddictUIIdentityContext
 {
-  DbSet<ClaimType> ClaimTypes { get; set; }
+  public DbSet<ClaimType> ClaimTypes { get; set; }
 }
 
 public class OpenIddictUIIdentityContext : OpenIddictUIIdentityContext<OpenIddictUIIdentityContext>
diff --git a/src/identity/OpenIddict.UI.Identity.Infrastructure/Services/AccountService.cs b/src/identity/OpenIddict.UI.Identity.Infrastructure/Services/AccountService.cs
@@ -82,14 +82,14 @@ public async Task<UserInfo> GetUserAsync(string id)
       Email = user.Email,
       LockoutEnabled = user.LockoutEnabled,
       IsLockedOut = isLockedOut,
-      Claims = new List<ClaimInfo>(claims.ToList().Select(x =>
+      Claims = [.. claims.ToList().Select(x =>
       {
         return new ClaimInfo
         {
           Type = x.Type,
           Value = x.Value
         };
-      })),
+      })],
       Roles = [.. roles]
     };
   }
@@ -116,10 +116,10 @@ public async Task<IdentityResult> UpdateAsync(UserParam model)
 
     result = await AssignClaimsAsync(
       user,
-      model.Claims.Select(x =>
+      [.. model.Claims.Select(x =>
       {
         return new Claim(x.Type, x.Value);
-      }).ToList()
+      })]
     );
     if (!result.Succeeded)
     {
diff --git a/src/openiddict/OpenIddict.UI.Infrastructure/Data/OpenIddictUIContext.cs b/src/openiddict/OpenIddict.UI.Infrastructure/Data/OpenIddictUIContext.cs
@@ -12,13 +12,13 @@ public class OpenIddictUIStoreOptions
 
 public interface IOpenIddictUIContext
 {
-  DbSet<OpenIddictEntityFrameworkCoreApplication> Applications { get; set; }
+  public DbSet<OpenIddictEntityFrameworkCoreApplication> Applications { get; set; }
 
-  DbSet<OpenIddictEntityFrameworkCoreAuthorization> Authorizations { get; set; }
+  public DbSet<OpenIddictEntityFrameworkCoreAuthorization> Authorizations { get; set; }
 
-  DbSet<OpenIddictEntityFrameworkCoreScope> Scopes { get; set; }
+  public DbSet<OpenIddictEntityFrameworkCoreScope> Scopes { get; set; }
 
-  DbSet<OpenIddictEntityFrameworkCoreToken> Tokens { get; set; }
+  public DbSet<OpenIddictEntityFrameworkCoreToken> Tokens { get; set; }
 }
 
 public class OpenIddictUIContext : OpenIddictUIContext<OpenIddictUIContext>
diff --git a/src/openiddict/OpenIddict.UI.Infrastructure/Interfaces/IApplicationService.cs b/src/openiddict/OpenIddict.UI.Infrastructure/Interfaces/IApplicationService.cs
@@ -5,13 +5,13 @@ namespace tomware.OpenIddict.UI.Infrastructure;
 
 public interface IApplicationService
 {
-  Task<IEnumerable<ApplicationInfo>> GetApplicationsAsync();
+  public Task<IEnumerable<ApplicationInfo>> GetApplicationsAsync();
 
-  Task<ApplicationInfo> GetAsync(string id);
+  public Task<ApplicationInfo> GetAsync(string id);
 
-  Task<string> CreateAsync(ApplicationParam model);
+  public Task<string> CreateAsync(ApplicationParam model);
 
-  Task UpdateAsync(ApplicationParam model);
+  public Task UpdateAsync(ApplicationParam model);
 
-  Task DeleteAsync(string id);
+  public Task DeleteAsync(string id);
 }
diff --git a/src/openiddict/OpenIddict.UI.Infrastructure/Interfaces/IScopeService.cs b/src/openiddict/OpenIddict.UI.Infrastructure/Interfaces/IScopeService.cs
@@ -5,13 +5,13 @@ namespace tomware.OpenIddict.UI.Infrastructure;
 
 public interface IScopeService
 {
-  Task<IEnumerable<ScopeInfo>> GetScopesAsync();
+  public Task<IEnumerable<ScopeInfo>> GetScopesAsync();
 
-  Task<ScopeInfo> GetAsync(string id);
+  public Task<ScopeInfo> GetAsync(string id);
 
-  Task<string> CreateAsync(ScopeParam model);
+  public Task<string> CreateAsync(ScopeParam model);
 
-  Task UpdateAsync(ScopeParam model);
+  public Task UpdateAsync(ScopeParam model);
 
-  Task DeleteAsync(string id);
+  public Task DeleteAsync(string id);
 }
diff --git a/src/suite/OpenIddict.UI.Suite.Core/Common/SimpleMapper.cs b/src/suite/OpenIddict.UI.Suite.Core/Common/SimpleMapper.cs
@@ -73,7 +73,7 @@ private static List<PropertyMap> GetMatchingProperties(Type source, Type target)
     var sourceProperties = source.GetProperties();
     var targetProperties = target.GetProperties();
 
-    return (from s in sourceProperties
+    return [.. from s in sourceProperties
             from t in targetProperties
             where string.Equals(s.Name, t.Name, StringComparison.Ordinal) &&
                   s.CanRead &&
@@ -83,7 +83,7 @@ where string.Equals(s.Name, t.Name, StringComparison.Ordinal) &&
             {
               SourceProperty = s,
               TargetProperty = t,
-            }).ToList();
+            }];
   }
 
   private static string GetMapKey(Type source, Type target) => $"{source.GetHashCode()}_{target.GetHashCode()}";
diff --git a/src/suite/OpenIddict.UI.Suite.Core/Interfaces/IAsyncRepository.cs b/src/suite/OpenIddict.UI.Suite.Core/Interfaces/IAsyncRepository.cs
@@ -6,10 +6,10 @@ namespace tomware.OpenIddict.UI.Suite.Core;
 public interface IAsyncRepository<TEntity, TKey>
   where TEntity : class
 {
-  Task<TEntity> GetByIdAsync(TKey id);
-  Task<IReadOnlyList<TEntity>> ListAsync(ISpecification<TEntity> spec);
-  Task<TEntity> AddAsync(TEntity entity);
-  Task UpdateAsync(TEntity entity);
-  Task DeleteAsync(TEntity entity);
-  Task<int> CountAsync(ISpecification<TEntity> spec);
+  public Task<TEntity> GetByIdAsync(TKey id);
+  public Task<IReadOnlyList<TEntity>> ListAsync(ISpecification<TEntity> spec);
+  public Task<TEntity> AddAsync(TEntity entity);
+  public Task UpdateAsync(TEntity entity);
+  public Task DeleteAsync(TEntity entity);
+  public Task<int> CountAsync(ISpecification<TEntity> spec);
 }
diff --git a/src/suite/OpenIddict.UI.Suite.Core/Interfaces/ISpecification.cs b/src/suite/OpenIddict.UI.Suite.Core/Interfaces/ISpecification.cs
@@ -6,15 +6,15 @@ namespace tomware.OpenIddict.UI.Suite.Core;
 
 public interface ISpecification<T>
 {
-  List<Expression<Func<T, bool>>> Criteria { get; }
-  List<Expression<Func<T, object>>> Includes { get; }
-  List<string> IncludeStrings { get; }
-  Expression<Func<T, object>> OrderBy { get; }
-  Expression<Func<T, object>> OrderByDescending { get; }
-  Expression<Func<T, object>> GroupBy { get; }
+  public List<Expression<Func<T, bool>>> Criteria { get; }
+  public List<Expression<Func<T, object>>> Includes { get; }
+  public List<string> IncludeStrings { get; }
+  public Expression<Func<T, object>> OrderBy { get; }
+  public Expression<Func<T, object>> OrderByDescending { get; }
+  public Expression<Func<T, object>> GroupBy { get; }
 
-  int Take { get; }
-  int Skip { get; }
-  bool IsPagingEnabled { get; }
-  bool AsNoTracking { get; }
+  public int Take { get; }
+  public int Skip { get; }
+  public bool IsPagingEnabled { get; }
+  public bool AsNoTracking { get; }
 }

Original file line number	Diff line number	Diff line change
`@@ -76,14 +76,14 @@ public async Task<UserViewModel> GetUserAsync(string id)`
`76`	`76`	`Email = user.Email,`
`77`	`77`	`LockoutEnabled = user.LockoutEnabled,`
`78`	`78`	`IsLockedOut = user.IsLockedOut,`
`79`		`- Claims = new List<ClaimViewModel>(user.Claims.Select(x =>`
	`79`	`+ Claims = [.. user.Claims.Select(x =>`
`80`	`80`	`{`
`81`	`81`	`return new ClaimViewModel`
`82`	`82`	`{`
`83`	`83`	`Type = x.Type,`
`84`	`84`	`Value = x.Value`
`85`	`85`	`};`
`86`		`- })),`
	`86`	`+ })],`
`87`	`87`	`Roles = user.Roles`
`88`	`88`	`};`
`89`	`89`	`}`
`@@ -98,14 +98,14 @@ public async Task<IdentityResult> UpdateAsync(UserViewModel model)`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`var param = SimpleMapper.From<UserViewModel, UserParam>(model);`
`101`		`- param.Claims = new List<ClaimInfo>(model.Claims.Select(c =>`
	`101`	`+ param.Claims = [.. model.Claims.Select(c =>`
`102`	`102`	`{`
`103`	`103`	`return new ClaimInfo`
`104`	`104`	`{`
`105`	`105`	`Type = c.Type,`
`106`	`106`	`Value = c.Value`
`107`	`107`	`};`
`108`		`- }));`
	`108`	`+ })];`
`109`	`109`
`110`	`110`	`return await _accountService.UpdateAsync(param);`
`111`	`111`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,13 +6,13 @@ namespace tomware.OpenIddict.UI.Identity.Core;`
`6`	`6`
`7`	`7`	`public interface IClaimTypeService`
`8`	`8`	`{`
`9`		`- Task<IEnumerable<ClaimTypeInfo>> GetClaimTypesAsync();`
	`9`	`+ public Task<IEnumerable<ClaimTypeInfo>> GetClaimTypesAsync();`
`10`	`10`
`11`		`- Task<ClaimTypeInfo> GetAsync(Guid id);`
	`11`	`+ public Task<ClaimTypeInfo> GetAsync(Guid id);`
`12`	`12`
`13`		`- Task<Guid> CreateAsync(ClaimTypeParam model);`
	`13`	`+ public Task<Guid> CreateAsync(ClaimTypeParam model);`
`14`	`14`
`15`		`- Task UpdateAsync(ClaimTypeParam model);`
	`15`	`+ public Task UpdateAsync(ClaimTypeParam model);`
`16`	`16`
`17`		`- Task DeleteAsync(Guid id);`
	`17`	`+ public Task DeleteAsync(Guid id);`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,5 +7,5 @@ public interface IUserCreationStrategy<TIdentityUser, TKey>`
`7`	`7`	`where TKey : IEquatable<TKey>`
`8`	`8`	`where TIdentityUser : IdentityUser<TKey>`
`9`	`9`	`{`
`10`		`- TIdentityUser CreateUser(RegisterUserParam model);`
	`10`	`+ public TIdentityUser CreateUser(RegisterUserParam model);`
`11`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public class OpenIddictUIIdentityStoreOptions`
`12`	`12`
`13`	`13`	`public interface IOpenIddictUIIdentityContext`
`14`	`14`	`{`
`15`		`- DbSet<ClaimType> ClaimTypes { get; set; }`
	`15`	`+ public DbSet<ClaimType> ClaimTypes { get; set; }`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`public class OpenIddictUIIdentityContext : OpenIddictUIIdentityContext<OpenIddictUIIdentityContext>`
Original file line number	Diff line number	Diff line change
`@@ -82,14 +82,14 @@ public async Task<UserInfo> GetUserAsync(string id)`
`82`	`82`	`Email = user.Email,`
`83`	`83`	`LockoutEnabled = user.LockoutEnabled,`
`84`	`84`	`IsLockedOut = isLockedOut,`
`85`		`- Claims = new List<ClaimInfo>(claims.ToList().Select(x =>`
	`85`	`+ Claims = [.. claims.ToList().Select(x =>`
`86`	`86`	`{`
`87`	`87`	`return new ClaimInfo`
`88`	`88`	`{`
`89`	`89`	`Type = x.Type,`
`90`	`90`	`Value = x.Value`
`91`	`91`	`};`
`92`		`- })),`
	`92`	`+ })],`
`93`	`93`	`Roles = [.. roles]`
`94`	`94`	`};`
`95`	`95`	`}`
`@@ -116,10 +116,10 @@ public async Task<IdentityResult> UpdateAsync(UserParam model)`
`116`	`116`
`117`	`117`	`result = await AssignClaimsAsync(`
`118`	`118`	`user,`
`119`		`- model.Claims.Select(x =>`
	`119`	`+ [.. model.Claims.Select(x =>`
`120`	`120`	`{`
`121`	`121`	`return new Claim(x.Type, x.Value);`
`122`		`- }).ToList()`
	`122`	`+ })]`
`123`	`123`	`);`
`124`	`124`	`if (!result.Succeeded)`
`125`	`125`	`{`
Original file line number	Diff line number	Diff line change
`@@ -12,13 +12,13 @@ public class OpenIddictUIStoreOptions`
`12`	`12`
`13`	`13`	`public interface IOpenIddictUIContext`
`14`	`14`	`{`
`15`		`- DbSet<OpenIddictEntityFrameworkCoreApplication> Applications { get; set; }`
	`15`	`+ public DbSet<OpenIddictEntityFrameworkCoreApplication> Applications { get; set; }`
`16`	`16`
`17`		`- DbSet<OpenIddictEntityFrameworkCoreAuthorization> Authorizations { get; set; }`
	`17`	`+ public DbSet<OpenIddictEntityFrameworkCoreAuthorization> Authorizations { get; set; }`
`18`	`18`
`19`		`- DbSet<OpenIddictEntityFrameworkCoreScope> Scopes { get; set; }`
	`19`	`+ public DbSet<OpenIddictEntityFrameworkCoreScope> Scopes { get; set; }`
`20`	`20`
`21`		`- DbSet<OpenIddictEntityFrameworkCoreToken> Tokens { get; set; }`
	`21`	`+ public DbSet<OpenIddictEntityFrameworkCoreToken> Tokens { get; set; }`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`public class OpenIddictUIContext : OpenIddictUIContext<OpenIddictUIContext>`
Original file line number	Diff line number	Diff line change
`@@ -5,13 +5,13 @@ namespace tomware.OpenIddict.UI.Infrastructure;`
`5`	`5`
`6`	`6`	`public interface IApplicationService`
`7`	`7`	`{`
`8`		`- Task<IEnumerable<ApplicationInfo>> GetApplicationsAsync();`
	`8`	`+ public Task<IEnumerable<ApplicationInfo>> GetApplicationsAsync();`
`9`	`9`
`10`		`- Task<ApplicationInfo> GetAsync(string id);`
	`10`	`+ public Task<ApplicationInfo> GetAsync(string id);`
`11`	`11`
`12`		`- Task<string> CreateAsync(ApplicationParam model);`
	`12`	`+ public Task<string> CreateAsync(ApplicationParam model);`
`13`	`13`
`14`		`- Task UpdateAsync(ApplicationParam model);`
	`14`	`+ public Task UpdateAsync(ApplicationParam model);`
`15`	`15`
`16`		`- Task DeleteAsync(string id);`
	`16`	`+ public Task DeleteAsync(string id);`
`17`	`17`	`}`