Skip to content

Commit c3c6c4d

Browse files
committed
fix: update success indicator logic in MarkdownTableParser and corresponding tests
1 parent 46c7ec6 commit c3c6c4d

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/testr.Cli/Domain/MarkdownTableParser.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ public IEnumerable<TestStep> ParseTestSteps()
3636

3737
// Parse the table rows
3838
var tableRows = ExtractTableRows(stepsSection);
39-
4039
foreach (var row in tableRows)
4140
{
4241
var testStep = ParseTableRow(row);
@@ -173,8 +172,7 @@ private static bool IsSeparatorRow(string line)
173172
{
174173
var actualResult = cells[4].Trim();
175174
// Check for success/failure indicators
176-
testStep.IsSuccess = actualResult.Contains("✅") ||
177-
actualResult.Equals("-", StringComparison.OrdinalIgnoreCase);
175+
testStep.IsSuccess = actualResult.Contains("✅");
178176
}
179177

180178
return testStep;

src/testr.Tests/MarkdownTableParserTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public void ParseTestSteps_WithSuccessFailureIndicators_ShouldSetIsSuccess()
8585
Assert.Equal(3, testSteps.Count);
8686
Assert.True(testSteps[0].IsSuccess); // ✅ indicates success
8787
Assert.False(testSteps[1].IsSuccess); // ❌ indicates failure
88-
Assert.True(testSteps[2].IsSuccess); // - indicates not run yet (considered success)
88+
Assert.False(testSteps[2].IsSuccess); // - indicates not run yet (considered failure)
8989
}
9090

9191
[Fact]

0 commit comments

Comments
 (0)