Remove for ... in loops

Author: thomasleplus

javascripts/DOM - Allow copy paste.js

@@ -1,10 +1,11 @@
 "use strict";
-var e;
-for (e in document.getElementsByTagName("*")) {
-    if (e.onCopy) {
-        e.onCopy = null;
+var e = document.getElementsByTagName("*");
+var i;
+for (i = 0; i < e.length; i += 1) {
+    if (e[i].onCopy) {
+        e[i].onCopy = null;
     }
-    if (e.onPaste) {
-        e.onPaste = null;
+    if (e[i].onPaste) {
+        e[i].onPaste = null;
     }
 }

javascripts/DOM - Allow save password.js

@@ -1,7 +1,8 @@
 "use strict";
-var e;
-for (e in document.getElementsByTagName("*")) {
-    if (e.autocomplete) {
-        e.autocomplete = 'on';
+var e = document.getElementsByTagName("*");
+var i;
+for (i = 0; i < e.length; i += 1) {
+    if (e[i].autocomplete) {
+        e[i].autocomplete = 'on';
     }
 }

javascripts/DOM - Enable all.js

@@ -1,7 +1,8 @@
 "use strict";
-var e;
-for (e in document.getElementsByTagName("*")) {
-    if (e.disabled) {
-        e.disabled = 'false';
+var e = document.getElementsByTagName("*");
+var i;
+for (i = 0; i < e.length; i += 1) {
+    if (e[i].disabled) {
+        e[i].disabled = 'false';
     }
 }

javascripts/DOM - Show anchors.js

@@ -1,8 +1,8 @@
 "use strict";
-var anchor, id;
+var i, id;
 var anchors = document.getElementsByTagName("a");
-for (anchor in anchors) {
-    id = anchor.id;
+for (i = 0; i < anchors.length; i += 1) {
+    id = anchors[i].id;
     if (id !== undefined && id.length > 0) {
         anchor.appendChild(document.createTextNode(" #" + id));
     }

javascripts/DOM - Show feeds.js

@@ -1,12 +1,13 @@
 "use strict";
 var msg = "";
 var links = document.getElementsByTagName("link");
-var link;
-for (link in links) {
-  if (link.rel === "alternate" && (link.type.indexOf("rss") !== -1 || link.type.indexOf("atom") !== -1 || link.type.indexOf("feed") !== -1)) {
-    msg += link.href + "\n";
-  }
+var i, link;
+for (i = 0; i < links.length; i += 1) {
+    link = links[i];
+    if (link.rel === "alternate" && (link.type.indexOf("rss") !== -1 || link.type.indexOf("atom") !== -1 || link.type.indexOf("feed") !== -1)) {
+        msg += link.href + "\n";
+    }
 }
 if (msg.length > 0) {
-  window.alert(msg);
+    window.alert(msg);
 }

javascripts/Google Maps to SunCalc.org.js

@@ -1,8 +1,8 @@
 "use strict";
 var pieces = location.href.split('/');
-var piece;
-var coordinates;
-for (piece in pieces) {
+var i, piece, coordinates;
+for (i = 0; i < pieces.length; i += 1) {
+    piece = pieces[i];
     if (piece.startsWith('@')) {
         piece = piece.substring(1).split(',');
         coordinates = piece[0] + ',' + piece[1] + ',19';