Skip to content

Commit fa38fd4

Browse files
committed
Use for ... in loops
1 parent 1c7e405 commit fa38fd4

File tree

5 files changed

+21
-28
lines changed

5 files changed

+21
-28
lines changed
Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
"use strict";
2-
var all = document.getElementsByTagName("*");
3-
var i;
4-
var max;
5-
for (i = 0, max = all.length; i < max; i += 1) {
6-
if (all[i].onCopy) {
7-
all[i].onCopy = null;
2+
var e;
3+
for (e in document.getElementsByTagName("*")) {
4+
if (e.onCopy) {
5+
e.onCopy = null;
86
}
9-
if (all[i].onPaste) {
10-
all[i].onPaste = null;
7+
if (e.onPaste) {
8+
e.onPaste = null;
119
}
1210
}
Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
"use strict";
2-
var all = document.getElementsByTagName("*");
3-
var i;
4-
var max;
5-
for (i = 0, max = all.length; i < max; i += 1) {
6-
if (all[i].autocomplete) {
7-
all[i].autocomplete = 'on';
2+
var e;
3+
for (e in document.getElementsByTagName("*")) {
4+
if (e.autocomplete) {
5+
e.autocomplete = 'on';
86
}
97
}

javascripts/DOM - Enable all.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
"use strict";
2-
var all = document.getElementsByTagName("*");
3-
var i;
4-
var max;
5-
for (i = 0, max = all.length; i < max; i += 1) {
6-
if (all[i].disabled) {
7-
all[i].disabled = 'false';
2+
var e;
3+
for (e in document.getElementsByTagName("*")) {
4+
if (e.disabled) {
5+
e.disabled = 'false';
86
}
97
}

javascripts/DOM - Show anchors.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
"use strict";
2-
var i, anchor, id;
2+
var anchor, id;
33
var anchors = document.getElementsByTagName("a");
4-
for (i = 0; i < anchors.length; i += 1) {
5-
anchor = anchors[i];
4+
for (anchor in anchors) {
65
id = anchor.id;
76
if (id !== undefined && id.length > 0) {
87
anchor.appendChild(document.createTextNode(" #" + id));

javascripts/Google Maps to SunCalc.org.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
"use strict";
22
var pieces = location.href.split('/');
3-
var i;
3+
var piece;
44
var coordinates;
5-
for (i = 0; i < pieces.length; i += 1) {
6-
if (pieces[i].startsWith('@')) {
7-
pieces = pieces[i].substring(1).split(',');
8-
coordinates = pieces[0] + ',' + pieces[1] + ',19';
5+
for (piece in pieces) {
6+
if (piece.startsWith('@')) {
7+
piece = piece.substring(1).split(',');
8+
coordinates = piece[0] + ',' + piece[1] + ',19';
99
break;
1010
}
1111
}

0 commit comments

Comments
 (0)