fix deploy-all

Author: thomast1906

.github/workflows/main.yml

@@ -70,8 +70,7 @@ jobs:
         commit_message: "Terraform fmt"
         file_pattern: "*.tf *.tfvars"
         commit_user_name: "github-actions[bot]"
-        commit_user_email: "41898282+github-actions[bot]@users.noreply.github.com"
-
+  
     - name: Terraform Plan
       run: terraform plan -no-color -input=false
       working-directory: ./2-Terraform-AZURE-Services-Creation/4-aks

2-Terraform-AZURE-Services-Creation/4-Create-AKS-Cluster-IAM-Roles.md

@@ -71,18 +71,12 @@ After creating the AKS cluster and IAM roles, consider these questions:
 
 ## 💡 Pro Tips
 
-1. **Migration from Existing Clusters**: If upgrading from a previous version of this tutorial:
-   - Kubernetes 1.33 requires a cluster upgrade procedure
-   - Azure RBAC is now enabled by default for enhanced security
-   - Auto-scaling may affect your cost structure but improves efficiency
-   - Network policies may require reviewing existing pod communication patterns
-
-2. **Security Best Practices**: 
+1. **Security Best Practices**: 
    - Enable Azure Policy for Kubernetes to enforce organisational standards and assess compliance at scale
    - Regularly review and audit RBAC permissions
    - Monitor cluster logs through the integrated Log Analytics workspace
 
-3. **Cost Optimization**:
+2. **Cost Optimisation**:
    - Auto-scaling will automatically adjust node count based on demand
    - Use spot instances for non-critical workloads to reduce costs
    - Monitor resource usage through Azure Monitor

4-kubernetes_manifest/2-Create-Kubernetes-Manifest.md

@@ -23,7 +23,7 @@ In this lab, you'll create and understand the Kubernetes manifest for deploying
 
 3. **Update the Image URL and Review Enhanced Features**
    Open `deployment.yml` and:
-   - [ ] Update line 24 with your ACR image URL (using tag v2 for the latest version)
+   - [ ] Update line 24 with your ACR image URL
    - [ ] Review the health checks (liveness and readiness probes) for improved reliability
    - [ ] Note the enhanced resource limits for better performance
    - [ ] Understand the container port configuration

CHANGELOG.md

@@ -55,18 +55,5 @@ All notable changes to this project will be documented in this file.
 - Improved setup instructions with latest tool versions
 - Added comprehensive changelog for tracking changes
 
-### Breaking Changes
-- Kubernetes 1.33 may require cluster upgrade procedures
-- Azure RBAC enabled by default (was previously disabled)
-- Network policies now enabled, may affect existing pod communications
-- Updated image tags require rebuilding and redeploying containers
-
-### Migration Notes
-- Update your local Terraform installation to v1.9.8 or higher
-- Verify Kubernetes 1.33 compatibility with your workloads
-- Review Azure RBAC permissions when upgrading existing clusters
-- Test network policies with your current pod communication patterns
-- Rebuild Docker images with updated Python 3.13 base image
-
 ## Previous Versions
 - Initial release with Kubernetes 1.32, Terraform 1.11.0, and Python 3.12

README.md

@@ -46,44 +46,6 @@ Get ready to utilise a range of cutting-edge technologies and platforms to estab
 | Checkov | Automated security testing | v3.2.4+ |
 | Terraform-docs | Documentation automation | Latest |
 
-## 🚀 Quick Start
-
-### Automated Deployment (Recommended for Testing)
-
-For a complete automated deployment and testing experience:
-
-```bash
-# Clone the repository
-git clone https://github.com/thomast1906/DevOps-The-Hard-Way-Azure.git
-cd DevOps-The-Hard-Way-Azure
-
-# Quick test (deploys everything, lets you test, then cleans up)
-./scripts/quick-test.sh
-
-# Or deploy everything and keep it running
-./scripts/deploy-all.sh
-
-# Clean up everything when done
-./scripts/cleanup-all.sh
-```
-
-### GitHub Actions Deployment
-
-The repository includes a comprehensive GitHub Actions workflow for automated deployment:
-
-1. **Fork this repository**
-2. **Set up Azure OIDC secrets** in your repository settings:
-   - `AZURE_AD_CLIENT_ID`
-   - `AZURE_AD_TENANT_ID` 
-   - `AZURE_SUBSCRIPTION_ID`
-3. **Trigger the workflow**:
-   - Push to `main` branch, or
-   - Use workflow dispatch with custom options
-
-The GitHub Actions workflow can deploy to different environments and optionally clean up resources after testing.
-
-### Manual Step-by-Step (Educational)
-
 Follow the detailed labs below for a complete learning experience.
 
 ## 🧪 Labs

Test-lab-only.md

@@ -0,0 +1,33 @@
+# Below is for testing the lab setup only
+
+### Automated Deployment
+
+For a complete automated deployment and testing experience:
+
+```bash
+# Clone the repository
+git clone https://github.com/thomast1906/DevOps-The-Hard-Way-Azure.git
+cd DevOps-The-Hard-Way-Azure
+
+
+# Or deploy everything and keep it running
+./scripts/deploy-all.sh
+
+# Clean up everything when done
+./scripts/cleanup-all.sh
+```
+
+### GitHub Actions Deployment
+
+The repository includes a comprehensive GitHub Actions workflow for automated deployment:
+
+1. **Fork this repository**
+2. **Set up Azure OIDC secrets** in your repository settings:
+   - `AZURE_AD_CLIENT_ID`
+   - `AZURE_AD_TENANT_ID` 
+   - `AZURE_SUBSCRIPTION_ID`
+3. **Trigger the workflow**:
+   - Push to `main` branch, or
+   - Use workflow dispatch with custom options
+
+The GitHub Actions workflow can deploy to different environments and optionally clean up resources after testing.

scripts/deploy-all.sh

@@ -137,13 +137,12 @@ terraform apply tfplan
 
 # Get AKS credentials
 echo -e "${YELLOW}📋 Getting AKS credentials...${NC}"
-az aks get-credentials --resource-group "$RESOURCE_GROUP" --name "${PROJECT_NAME}aks" --overwrite-existing
-cd ../../scripts
+az aks get-credentials --resource-group "$RESOURCE_GROUP" --name "${PROJECT_NAME}aks" --overwrite-existing --admin
 echo ""
 
 # Step 5: Build and Push Docker Image
 print_step "8" "Building and Pushing Docker Image"
-cd "../3-Docker"
+cd "3-Docker"
 
 echo -e "${YELLOW}📋 Building Docker image for AMD64 platform...${NC}"
 docker build --platform linux/amd64 -t "${PROJECT_NAME}azurecr.azurecr.io/thomasthorntoncloud:v2" .
@@ -153,12 +152,12 @@ az acr login --name "${PROJECT_NAME}azurecr"
 
 echo -e "${YELLOW}📋 Pushing image to ACR...${NC}"
 docker push "${PROJECT_NAME}azurecr.azurecr.io/thomasthorntoncloud:v2"
-cd ../scripts
+cd ..
 echo ""
 
 # Step 6: Deploy Kubernetes Resources
 print_step "9" "Deploying Application to Kubernetes"
-cd "../4-kubernetes_manifest"
+cd "4-kubernetes_manifest"
 
 echo -e "${YELLOW}📋 Deploying application manifest...${NC}"
 kubectl apply -f deployment.yml
@@ -177,7 +176,7 @@ chmod +x scripts/2-gateway-api-resources.sh
 echo -e "${YELLOW}📋 Waiting for application to be ready...${NC}"
 kubectl wait --for=condition=available --timeout=300s deployment/thomasthornton -n thomasthorntoncloud
 
-cd ../scripts
+cd ..
 echo ""
 
 # Step 7: Get Application URL