Skip to content

Commit e9e6c5b

Browse files
committed
Change exception throwing of the sanitize_filename function
1 parent bec6c36 commit e9e6c5b

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

pathvalidate/__init__.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,13 @@ def sanitize_filename(filename, replacement_text=""):
136136
:param str replacement_text: Replacement text.
137137
:return: A replacement string.
138138
:rtype: str
139+
:raises ValueError: If the ``filename`` is a invalid filename.
139140
"""
140141

141-
return __RE_INVALID_FILENAME.sub(replacement_text, filename.strip())
142+
try:
143+
return __RE_INVALID_FILENAME.sub(replacement_text, filename.strip())
144+
except AttributeError as e:
145+
raise ValueError(e)
142146

143147

144148
def sanitize_file_path(file_path, replacement_text=""):

test/test_pathvalidate.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,9 @@ def test_normal(self, value, replace_text, expected):
210210
validate_filename(sanitized_name)
211211

212212
@pytest.mark.parametrize(["value", "expected"], [
213-
[None, AttributeError],
214-
[1, AttributeError],
215-
[True, AttributeError],
213+
[None, ValueError],
214+
[1, ValueError],
215+
[True, ValueError],
216216
])
217217
def test_exception_type(self, value, expected):
218218
with pytest.raises(expected):

0 commit comments

Comments
 (0)