Skip to content

Commit f7fd0b0

Browse files
committed
chore: enforce typescript checks
1 parent 371df79 commit f7fd0b0

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,9 @@ jobs:
117117
run: yarn install --frozen-lockfile
118118
# End of yarn setup
119119

120+
- name: typescript checks
121+
run: yarn typescript
122+
120123
# We have to build all the packages before the tests
121124
# Because init-log4brains's integration tests use @log4brains/cli, which uses @log4brains/core
122125
# TODO: we should separate tests that require built packages of the others, to get a quicker feedback

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,9 @@ jobs:
119119
# - steps.yarn-lock.outcome == 'success' --> yarn.lock was not changed
120120
# - steps.yarn-lock.outcome == 'failure' --> yarn.lock was changed
121121

122+
- name: typescript checks
123+
run: yarn typescript
124+
122125
# We have to build all the packages before the tests
123126
# Because init-log4brains's integration tests use @log4brains/cli, which uses @log4brains/core
124127
# TODO: we should separate tests that require built packages of the others, to get a quicker feedback

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ When you are done, run `yarn unlink-cli && npm install -g log4brains` to use the
5252
```bash
5353
yarn lint # enforced automatically before every commit with husky+lint-staged
5454
yarn format:fix # enforced automatically before every commit with husky+lint-staged
55+
yarn typescript # enforced automatically before every commit with husky
5556
yarn test:changed # (or `yarn test` to run all the tests)
5657
```
5758

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
},
6565
"husky": {
6666
"hooks": {
67-
"pre-commit": "lint-staged",
67+
"pre-commit": "lint-staged && yarn typescript",
6868
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
6969
}
7070
},

0 commit comments

Comments
 (0)