From a5de26c7adc22c8b02a62894c7b57adc1aebee09 Mon Sep 17 00:00:00 2001 From: berkay Date: Fri, 21 Nov 2025 00:38:19 +0100 Subject: [PATCH 1/3] chore: update Node.js engine version to >=20 in package.json files --- package.json | 6 +++--- packages/cli-common/package.json | 2 +- packages/cli/package.json | 2 +- packages/core/package.json | 2 +- packages/global-cli/package.json | 2 +- packages/init/package.json | 2 +- packages/web/package.json | 6 +++--- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/package.json b/package.json index 75a9230..893c3d9 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "root", "private": true, "engines": { - "node": ">=18" + "node": ">=20" }, "workspaces": [ "packages/**" @@ -29,7 +29,7 @@ "@commitlint/cli": "^11.0.0", "@commitlint/config-conventional": "^11.0.0", "@types/jest": "^26.0.14", - "@types/node": "^14.11.2", + "@types/node": "^20.0.0", "@types/rimraf": "^3.0.0", "@typescript-eslint/eslint-plugin": "^4.2.0", "@typescript-eslint/parser": "^4.2.0", @@ -58,7 +58,7 @@ "serve": "^11.3.2", "ts-jest": "^26.4.0", "typedoc": "0.17.0-3", - "typescript": "^4.0.3" + "typescript": "^5.2.2" }, "husky": { "hooks": { diff --git a/packages/cli-common/package.json b/packages/cli-common/package.json index 7d39be4..f9cfdf4 100644 --- a/packages/cli-common/package.json +++ b/packages/cli-common/package.json @@ -18,7 +18,7 @@ "directory": "packages/cli-common" }, "engines": { - "node": ">=18" + "node": ">=20" }, "files": [ "dist" diff --git a/packages/cli/package.json b/packages/cli/package.json index e4e03df..3c327d7 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -18,7 +18,7 @@ "directory": "packages/cli" }, "engines": { - "node": ">=18" + "node": ">=20" }, "files": [ "dist" diff --git a/packages/core/package.json b/packages/core/package.json index c357449..6af22af 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -18,7 +18,7 @@ "directory": "packages/core" }, "engines": { - "node": ">=18" + "node": ">=20" }, "files": [ "dist" diff --git a/packages/global-cli/package.json b/packages/global-cli/package.json index ee1b73f..5c0a251 100644 --- a/packages/global-cli/package.json +++ b/packages/global-cli/package.json @@ -28,7 +28,7 @@ "directory": "packages/global-cli" }, "engines": { - "node": ">=18" + "node": ">=20" }, "files": [ "dist" diff --git a/packages/init/package.json b/packages/init/package.json index 3cbe113..337460e 100644 --- a/packages/init/package.json +++ b/packages/init/package.json @@ -18,7 +18,7 @@ "directory": "packages/init" }, "engines": { - "node": ">=18" + "node": ">=20" }, "files": [ "assets", diff --git a/packages/web/package.json b/packages/web/package.json index 4fc5604..8bce5f0 100644 --- a/packages/web/package.json +++ b/packages/web/package.json @@ -18,7 +18,7 @@ "directory": "packages/web" }, "engines": { - "node": ">=18" + "node": ">=20" }, "files": [ "dist", @@ -52,7 +52,7 @@ "@material-ui/icons": "^4.9.1", "@material-ui/lab": "^4.0.0-alpha.56", "@next/bundle-analyzer": "^10.0.1", - "@types/node": "^15.0.1", + "@types/node": "^20.0.0", "@types/react": "17.0.4", "babel-plugin-import": "^1.13.1", "badge-maker": "^3.3.0", @@ -73,7 +73,7 @@ "slugify": "^1.4.5", "socket.io": "^2.3.0", "socket.io-client": "^2.3.1", - "typescript": "^4.0.3" + "typescript": "^5.2.2" }, "devDependencies": { "@babel/core": "^7.11.6", From 4d1a7b6d94303aa224be43cc9c53889e44884573 Mon Sep 17 00:00:00 2001 From: berkay Date: Fri, 21 Nov 2025 00:50:48 +0100 Subject: [PATCH 2/3] chore: format files and fix preview request handler lint --- .../src/infrastructure/config/builders.ts | 2 +- packages/web/cli/commands/preview.ts | 8 ++++-- yarn.lock | 25 ++++++++++++------- 3 files changed, 23 insertions(+), 12 deletions(-) diff --git a/packages/core/src/infrastructure/config/builders.ts b/packages/core/src/infrastructure/config/builders.ts index 2c1e32a..e6bd4c0 100644 --- a/packages/core/src/infrastructure/config/builders.ts +++ b/packages/core/src/infrastructure/config/builders.ts @@ -77,7 +77,7 @@ export function buildConfigFromWorkdir(workdir = "."): Log4brainsConfig { } throw new Log4brainsError( `Impossible to read the ${configFilename} config file`, - e + e instanceof Error ? e.message : String(e) ); } } diff --git a/packages/web/cli/commands/preview.ts b/packages/web/cli/commands/preview.ts index b1e00b7..497a212 100644 --- a/packages/web/cli/commands/preview.ts +++ b/packages/web/cli/commands/preview.ts @@ -47,8 +47,12 @@ export async function previewCommand( // @ts-ignore app.server.incrementalCache.incrementalOptions.dev = true; // eslint-disable-line @typescript-eslint/no-unsafe-member-access - // eslint-disable-next-line @typescript-eslint/no-misused-promises - const srv = createServer(app.getRequestHandler()); + // Create server and attach Next's request handler without returning a Promise + const srv = createServer(); + const handler = app.getRequestHandler(); + srv.on("request", (req, res) => { + void handler(req, res); + }); // FileWatcher with Socket.io const io = SocketIO(srv); diff --git a/yarn.lock b/yarn.lock index bc9a50a..b2d911c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3886,15 +3886,17 @@ resolved "https://registry.yarnpkg.com/@types/node/-/node-15.0.1.tgz#ef34dea0881028d11398be5bf4e856743e3dc35a" integrity sha512-TMkXt0Ck1y0KKsGr9gJtWGjttxlZnnvDtphxUOSd0bfaR6Q1jle+sPvrzNR1urqYTWMinoKvjKfXUGsumaO1PA== -"@types/node@^14.0.10", "@types/node@^14.11.2": +"@types/node@^14.0.10": version "14.14.43" resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.43.tgz#26bcbb0595b305400e8ceaf9a127a7f905ae49c8" integrity sha512-3pwDJjp1PWacPTpH0LcfhgjvurQvrZFBrC6xxjaUEZ7ifUtT32jtjPxEMMblpqd2Mvx+k8haqQJLQxolyGN/cQ== -"@types/node@^15.0.1": - version "15.14.9" - resolved "https://registry.yarnpkg.com/@types/node/-/node-15.14.9.tgz#bc43c990c3c9be7281868bbc7b8fdd6e2b57adfa" - integrity sha512-qjd88DrCxupx/kJD5yQgZdcYKZKSIGBVDIBE1/LTGcNm3d2Np/jxojkdePDdfnBHJc5W7vSMpbJ1aB7p/Py69A== +"@types/node@^20.0.0": + version "20.19.25" + resolved "https://registry.yarnpkg.com/@types/node/-/node-20.19.25.tgz#467da94a2fd966b57cc39c357247d68047611190" + integrity sha512-ZsJzA5thDQMSQO788d7IocwwQbI8B5OPzmqNvpf3NY/+MHDAS759Wo0gd2WQeXYt5AAAQjzcrTVC6SKCuYgoCQ== + dependencies: + undici-types "~6.21.0" "@types/normalize-package-data@^2.4.0": version "2.4.0" @@ -18056,10 +18058,10 @@ typescript@^3.2.1, typescript@^3.9.5: resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.9.9.tgz#e69905c54bc0681d0518bd4d587cc6f2d0b1a674" integrity sha512-kdMjTiekY+z/ubJCATUPlRDl39vXYiMV9iyeMuEuXZh2we6zz80uovNN2WlAxmmdE/Z/YQe+EbOEXB5RHEED3w== -typescript@^4.0.3: - version "4.2.4" - resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.2.4.tgz#8610b59747de028fda898a8aef0e103f156d0961" - integrity sha512-V+evlYHZnQkaz8TRBuxTA92yZBPotr5H+WhQ7bD3hZUndx5tGOa1fuCgeSjxAzM1RiN5IzvadIXTVefuuwZCRg== +typescript@^5.2.2: + version "5.9.3" + resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.9.3.tgz#5b4f59e15310ab17a216f5d6cf53ee476ede670f" + integrity sha512-jl1vZzPDinLr9eUt3J/t7V6FgNEw9QjvBPdysz9KfQDD41fQrC2Y4vKQdiaUpFT4bXlb1RHhLpp8wtm6M5TgSw== uc.micro@^2.0.0, uc.micro@^2.1.0: version "2.1.0" @@ -18103,6 +18105,11 @@ underscore@>=1.8.3, underscore@^1.9.1: resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.13.1.tgz#0c1c6bd2df54b6b69f2314066d65b6cde6fcf9d1" integrity sha512-hzSoAVtJF+3ZtiFX0VgfFPHEDRm7Y/QPjGyNo4TVdnDTdft3tr8hEkD25a1jC+TjTuE7tkHGKkhwCgs9dgBB2g== +undici-types@~6.21.0: + version "6.21.0" + resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-6.21.0.tgz#691d00af3909be93a7faa13be61b3a5b50ef12cb" + integrity sha512-iwDZqg0QAGrg9Rav5H4n0M64c3mkR59cJ6wQp+7C4nI0gsmExaedaYLNO44eT4AtBBwjbTiGPMlt2Md0T9H9JQ== + unfetch@^4.2.0: version "4.2.0" resolved "https://registry.yarnpkg.com/unfetch/-/unfetch-4.2.0.tgz#7e21b0ef7d363d8d9af0fb929a5555f6ef97a3be" From 6cc803d085d0ebdfbbe45790a5f8dedde998fbc7 Mon Sep 17 00:00:00 2001 From: berkay Date: Fri, 21 Nov 2025 00:54:46 +0100 Subject: [PATCH 3/3] fix(cli): add explicit types to preview request handler --- packages/web/cli/commands/preview.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/web/cli/commands/preview.ts b/packages/web/cli/commands/preview.ts index 497a212..7d1068b 100644 --- a/packages/web/cli/commands/preview.ts +++ b/packages/web/cli/commands/preview.ts @@ -47,7 +47,6 @@ export async function previewCommand( // @ts-ignore app.server.incrementalCache.incrementalOptions.dev = true; // eslint-disable-line @typescript-eslint/no-unsafe-member-access - // Create server and attach Next's request handler without returning a Promise const srv = createServer(); const handler = app.getRequestHandler(); srv.on("request", (req, res) => {