refactor: migrated solution id route (#3834)

Author: thorsten

.docker/frankenphp/Caddyfile

@@ -28,10 +28,6 @@
         php_server
     }
 
-    # Solution ID pages
-    @solution_id path_regexp solution ^/solution_id_([0-9]+)\.html$
-    rewrite @solution_id /index.php?solution_id={re.solution.1}
-
     # Google sitemap
     rewrite /sitemap.xml /index.php
     rewrite /sitemap.gz /index.php
@@ -106,10 +102,6 @@
         php_server
     }
 
-    # Solution ID pages
-    @solution_id path_regexp solution ^/solution_id_([0-9]+)\.html$
-    rewrite @solution_id /index.php?solution_id={re.solution.1}
-
     # Google sitemap
     rewrite /sitemap.xml /index.php
     rewrite /sitemap.gz /index.php

.docker/nginx/default.conf

@@ -217,9 +217,6 @@ server {
 
     location @rewriteapp {
 
-        # a solution id page
-        rewrite ^/solution_id_([0-9]+)\.html$                      /index.php?solution_id=$1 last;
-
         # PMF Google sitemap
         rewrite ^/sitemap\.xml$                                     /index.php last;
         rewrite ^/sitemap\.gz$                                      /index.php last;

nginx.conf

@@ -88,9 +88,6 @@ server {
 
     location @rewriteapp {
 
-        # a solution id page
-        rewrite ^/solution_id_([0-9]+)\.html$                       /index.php?solution_id=$1 last;
-
         # PMF Google sitemap
         rewrite ^/sitemap\.xml$                                     /index.php last;
         rewrite ^/sitemap\.gz$                                      /index.php last;

phpmyfaq/.htaccess

@@ -104,11 +104,6 @@ Header set Access-Control-Allow-Headers "Content-Type, Authorization"
     RewriteRule ^(admin/assets)($|/) - [L]
     # Error pages
     ErrorDocument 404 /404.html
-    # a solution ID page
-    RewriteCond %{REQUEST_URI} solution_id_([0-9]+)\.html$ [NC]
-    RewriteRule ^solution_id_(.*)\.html$ index.php?solution_id=$1 [L,QSA]
-    # phpMyFAQ news page
-    RewriteRule ^news/([0-9]+)/([a-z\-_]+)/(.+)\.htm(l?)$ index.php?action=news&newsid=$1&newslang=$2 [L,QSA]
     # phpMyFAQ Google sitemap
     RewriteRule ^sitemap.xml$ index.php [L,QSA]
     RewriteRule ^sitemap.gz$ index.php [L,QSA]
@@ -136,7 +131,6 @@ Header set Access-Control-Allow-Headers "Content-Type, Authorization"
     RewriteCond %{REQUEST_URI} !index\.php$
     RewriteRule ^(.*/)?setup/(.*) $1setup/index.php [L,QSA]
     RewriteRule ^update$ update/ [R=301,L]
-
     # Front controller: route all requests to index.php (Symfony Router)
     # Skip if the file or directory exists
     RewriteCond %{REQUEST_FILENAME} !-f

phpmyfaq/src/phpMyFAQ/Controller/Frontend/FaqController.php

@@ -137,10 +137,42 @@ public function add(Request $request): Response
         return $this->render('add.twig', $templateVars);
     }
 
+    /**
+     * Redirects solution_id URLs to the actual FAQ page
+     *
+     * @throws Exception|\Exception
+     */
+    #[Route(path: '/solution_id_{solutionId}.html', name: 'public.faq.solution', methods: ['GET'])]
+    public function solution(Request $request): Response
+    {
+        $solutionId = Filter::filterVar($request->attributes->get('solutionId'), FILTER_VALIDATE_INT, 0);
+
+        if ($solutionId === 0) {
+            return new Response('', Response::HTTP_NOT_FOUND);
+        }
+
+        $faq = $this->container->get('phpmyfaq.faq');
+        $faqData = $faq->getIdFromSolutionId($solutionId);
+
+        if (empty($faqData)) {
+            return new Response('', Response::HTTP_NOT_FOUND);
+        }
+
+        // Generate a simple slug from the question title
+        $slug = preg_replace('/[^a-z0-9]+/i', '-', strtolower($faqData['question'] ?? 'faq'));
+        $slug = trim($slug, '-') ?: 'faq';
+
+        // Redirect to the canonical FAQ URL
+        $url = sprintf('/faq/%d/%d/%s.html', $faqData['category_id'], $faqData['id'], $slug);
+
+        return new RedirectResponse($url, Response::HTTP_MOVED_PERMANENTLY);
+    }
+
     /**
      * Displays a single FAQ article with comments, ratings, and related content
      *
-     * @throws Exception
+     * @throws Exception|LoaderError*@throws \Exception
+     *
      */
     #[Route(path: '/faq/{categoryId}/{faqId}/{slug}.html', name: 'public.faq.show', methods: ['GET'])]
     public function show(Request $request): Response
@@ -265,7 +297,7 @@ public function show(Request $request): Response
             'title' => sprintf('%s - %s', $seoData->getTitle() ?? $question, $this->configuration->getTitle()),
             'metaDescription' => $seoData->getDescription(),
             'solutionId' => $faq->faqRecord['solution_id'],
-            'solutionIdLink' => Link::getSystemRelativeUri() . '?solution_id=' . $faq->faqRecord['solution_id'],
+            'solutionIdLink' => './solution_id_' . $faq->faqRecord['solution_id'] . '.html',
             'breadcrumb' => $category->getPathWithStartpage($cat, '/', true),
             'question' => $question,
             'answer' => $answer,

phpmyfaq/src/public-routes.php

@@ -69,6 +69,11 @@
         'controller' => [FaqController::class, 'add'],
         'methods' => 'GET',
     ],
+    'public.faq.solution' => [
+        'path' => '/solution_id_{solutionId}.html',
+        'controller' => [FaqController::class, 'solution'],
+        'methods' => 'GET',
+    ],
     'public.faq.show' => [
         'path' => '/faq/{categoryId}/{faqId}/{slug}.html',
         'controller' => [FaqController::class, 'show'],