fix: improved linting result

Author: thorsten

phpmyfaq/src/phpMyFAQ/Attachment/File.php

@@ -32,7 +32,7 @@
 class File extends AbstractAttachment implements AttachmentInterface
 {
     /**
-     * Build a file path under which the attachment, file is accessible in filesystem
+     * Build a file path under which the attachment file is accessible in filesystem
      *
      * @throws AttachmentException
      */
@@ -62,7 +62,7 @@ public function createSubDirs(string $filepath): bool
         clearstatcache();
         $attDir = dirname($filepath);
 
-        return file_exists($attDir) && is_dir($attDir) || mkdir($attDir, 0777, true);
+        return file_exists($attDir) && is_dir($attDir) || mkdir($attDir, 0o777, true);
     }
 
     /**
@@ -85,7 +85,7 @@ public function isStorageOk(): bool
     }
 
     /**
-     * Save current attachment to the appropriate storage.
+     * Save the current attachment to the appropriate storage.
      * The filepath given will be processed and moved to the appropriate location.
      *
      * @param string $filePath full path to the attachment file

phpmyfaq/src/phpMyFAQ/Category/Image.php

@@ -135,7 +135,7 @@ public function upload(): bool
 
             // Ensure destination directory exists
             if (!is_dir(self::UPLOAD_DIR)) {
-                if (!@mkdir(self::UPLOAD_DIR, 0775, true) && !is_dir(self::UPLOAD_DIR)) {
+                if (!@mkdir(self::UPLOAD_DIR, 0o775, true) && !is_dir(self::UPLOAD_DIR)) {
                     throw new Exception('Upload directory does not exist and could not be created: '
                     . self::UPLOAD_DIR);
                 }

phpmyfaq/src/phpMyFAQ/Helper/StatisticsHelper.php

@@ -75,11 +75,8 @@ public function getFirstTrackingDate(int $firstDate): string
         $date = 0;
 
         if (is_file(PMF_ROOT_DIR . '/content/core/data/tracking' . date(format: 'dmY', timestamp: $firstDate))) {
-            $fp = @fopen(
-                PMF_ROOT_DIR . '/content/core/data/tracking' . date(format: 'dmY', timestamp: $firstDate),
-                'r',
-            );
-            while (($data = fgetcsv($fp, 1024, ';', '"', '\\')) !== false) {
+            $fp = fopen(PMF_ROOT_DIR . '/content/core/data/tracking' . date(format: 'dmY', timestamp: $firstDate), 'r');
+            while (($data = fgetcsv($fp, length: 1024, separator: ';', enclosure: '"', escape: '\\')) !== false) {
                 $date = isset($data[7]) && 10 === strlen($data[7]) ? $data[7] : $requestTime;
             }
 
@@ -98,7 +95,7 @@ public function getLastTrackingDate(int $lastDate): string
         if (is_file(PMF_ROOT_DIR . '/content/core/data/tracking' . date(format: 'dmY', timestamp: $lastDate))) {
             $fp = fopen(PMF_ROOT_DIR . '/content/core/data/tracking' . date(format: 'dmY', timestamp: $lastDate), 'r');
 
-            while (($data = fgetcsv($fp, 1024, ';', '"', '\\')) !== false) {
+            while (($data = fgetcsv($fp, length: 1024, separator: ';', enclosure: '"', escape: '\\')) !== false) {
                 $date = isset($data[7]) && 10 === strlen($data[7]) ? $data[7] : $requestTime;
             }
 
@@ -186,7 +183,7 @@ public function clearAllVisits(): bool
 
     public function renderMonthSelector(): string
     {
-        $oldValue = mktime(0, 0, 0, 1, 1, 1970);
+        $oldValue = mktime(hour: 0, minute: 0, second: 0, month: 1, day: 1, year: 1970);
         $renderedHtml = sprintf('<option value="" selected>%s</option>', Translation::get(key: 'ad_stat_choose'));
 
         $trackingDates = $this->getAllTrackingDates();
@@ -213,8 +210,11 @@ public function renderDaySelector(): string
         $renderedHtml = '';
 
         if ($trackingDates === []) {
-            return $renderedHtml
-            . sprintf('<option value="" selected>%s</option>', Translation::get(key: 'ad_stat_choose'));
+            return sprintf(
+                '%s<option value="" selected>%s</option>',
+                $renderedHtml,
+                Translation::get(key: 'ad_stat_choose'),
+            );
         }
 
         foreach ($trackingDates as $trackingDate) {

phpmyfaq/src/phpMyFAQ/Instance/Setup.php

@@ -82,7 +82,7 @@ public function checkDirs(array $dirs): array
                 if (false === mkdir($this->rootDir . $dir)) {
                     // If the folder creation fails
                     $failedDirs[] = 'Folder [' . $dir . '] could not be created.';
-                } elseif (false === chmod($this->rootDir . $dir, 0775)) {
+                } elseif (false === chmod($this->rootDir . $dir, 0o775)) {
                     $failedDirs[] = 'Folder [' . $dir . '] could not be given correct permissions (775).';
                 }
             } elseif (false === is_writable($this->rootDir . $dir)) {