fix: corrected fatal error on basic permissions when viewing news

Author: thorsten

phpmyfaq/src/phpMyFAQ/Permission/BasicPermission.php

@@ -20,6 +20,7 @@
 use phpMyFAQ\Configuration;
 use phpMyFAQ\Core\Exception;
 use phpMyFAQ\Database;
+use phpMyFAQ\Enums\PermissionType;
 use phpMyFAQ\User\CurrentUser;
 
 /**
@@ -131,8 +132,8 @@ public function hasPermission(int $userId, mixed $right): bool
             return true;
         }
 
-        if (!is_numeric($right) && is_string($right)) {
-            $right = $this->getRightId($right);
+        if ($right instanceof PermissionType) {
+            $right = $this->getRightId($right->value);
         }
 
         return $this->checkUserRight($currentUser->getUserId(), $right);

tests/phpMyFAQ/Permission/BasicPermissionTest.php

@@ -54,7 +54,7 @@ public function testHasPermission(): void
     {
         $this->assertTrue($this->basicPermission->hasPermission(1, 1));
         $this->assertFalse($this->basicPermission->hasPermission(-1, 1));
-        $this->assertFalse($this->basicPermission->hasPermission(-1, PermissionType::USER_ADD->value));
+        $this->assertFalse($this->basicPermission->hasPermission(-1, PermissionType::USER_ADD));
     }
 
     public function testGetRightId(): void