fix: corrected environment configurator (#3834)

Author: thorsten

phpmyfaq/src/phpMyFAQ/Setup/EnvironmentConfigurator.php

@@ -73,7 +73,7 @@ public function getRewriteBase(): string
      * This method ensures that URL routing works correctly and 404 errors are properly handled.
      *
      * - RewriteBase is set to the application's installation path (e.g., /faq/)
-     * - ErrorDocument 404 is configured to route errors to the application's error handler (e.g., /faq/index.php?action=404)
+     * - ErrorDocument 404 is configured to route errors to the application's error handler (e.g., /404.html)
      *
      * @return bool Returns true if the .htaccess file was successfully modified, false otherwise.
      * @throws Exception If the .htaccess file does not exist or contains syntax errors during parsing.
@@ -110,7 +110,7 @@ public function adjustRewriteBaseHtaccess(): bool
                 $errorDocument404->removeArgument($arg);
             }
             // Set new arguments: error code and path
-            $new404Path = rtrim($this->getServerPath(), '/') . '/index.php?action=404';
+            $new404Path = rtrim($this->getServerPath(), '/') . '/404.html';
             $errorDocument404->setArguments(['404', $new404Path]);
         }
 

tests/phpMyFAQ/Setup/EnvironmentConfiguratorTest.php

@@ -102,7 +102,7 @@ public function testAdjustRewriteBaseHtaccessUpdatesErrorDocumentWithRootPath():
 <IfModule mod_rewrite.c>
     RewriteEngine On
     RewriteBase /phpmyfaq-test/
-    ErrorDocument 404 /phpmyfaq-test/index.php?action=404
+    ErrorDocument 404 /404.html
 </IfModule>
 HTACCESS;
         file_put_contents($htaccessPath, $htaccessContent);
@@ -115,7 +115,7 @@ public function testAdjustRewriteBaseHtaccessUpdatesErrorDocumentWithRootPath():
 
         // Read the .htaccess file and verify ErrorDocument 404 is set correctly
         $htaccessContent = file_get_contents($htaccessPath);
-        $this->assertStringContainsString('ErrorDocument 404 /index.php?action=404', $htaccessContent);
+        $this->assertStringContainsString('ErrorDocument 404 /404.html', $htaccessContent);
     }
 
     /**
@@ -130,7 +130,7 @@ public function testAdjustRewriteBaseHtaccessUpdatesErrorDocumentWithSubdirector
 <IfModule mod_rewrite.c>
     RewriteEngine On
     RewriteBase /
-    ErrorDocument 404 /index.php?action=404
+    ErrorDocument 404 /404.html
 </IfModule>
 HTACCESS;
         file_put_contents($htaccessPath, $htaccessContent);
@@ -143,6 +143,6 @@ public function testAdjustRewriteBaseHtaccessUpdatesErrorDocumentWithSubdirector
 
         // Read the .htaccess file and verify ErrorDocument 404 is set correctly
         $htaccessContent = file_get_contents($htaccessPath);
-        $this->assertStringContainsString('ErrorDocument 404 /faq/index.php?action=404', $htaccessContent);
+        $this->assertStringContainsString('ErrorDocument 404 /faq/404.html', $htaccessContent);
     }
 }