fix: corrected issues regarding the Symfony 7.4 update

Author: thorsten

phpmyfaq/assets/templates/default/ucp.twig

@@ -306,9 +306,14 @@
           <form action="{{ exportUserDataUrl }}" method="post">
             {{ csrfExportUserData | raw }}
             <input type="hidden" name="userid" value="{{ userid }}" />
-            <button type="submit" class="btn btn-success">
-              <i aria-hidden="true" class="bi bi-download"></i> {{ msgDownload }}
-            </button>
+
+            <div class="row">
+              <div class="col-12 text-end">
+                <button type="submit" class="btn btn-primary">
+                  <i aria-hidden="true" class="bi bi-download"></i> {{ msgDownload }}
+                </button>
+              </div>
+            </div>
           </form>
         </div>
       </div>

phpmyfaq/index.php

@@ -138,16 +138,16 @@
 $error = null;
 $loginVisibility = 'hidden';
 
-$faqusername = Filter::filterVar($request->attributes->get('faqusername'), FILTER_SANITIZE_SPECIAL_CHARS);
+$faqusername = Filter::filterVar($request->request->get('faqusername'), FILTER_SANITIZE_SPECIAL_CHARS);
 $faqpassword = Filter::filterVar(
-    $request->attributes->get('faqpassword'),
+    $request->request->get('faqpassword'),
     FILTER_SANITIZE_SPECIAL_CHARS,
     FILTER_FLAG_NO_ENCODE_QUOTES,
 );
-$faqaction = Filter::filterVar($request->attributes->get('faqloginaction'), FILTER_SANITIZE_SPECIAL_CHARS);
-$rememberMe = Filter::filterVar($request->attributes->get('faqrememberme'), FILTER_VALIDATE_BOOLEAN);
-$token = Filter::filterVar($request->attributes->get('token'), FILTER_SANITIZE_SPECIAL_CHARS);
-$userId = Filter::filterVar($request->attributes->get('userid'), FILTER_VALIDATE_INT);
+$faqaction = Filter::filterVar($request->request->get('faqloginaction'), FILTER_SANITIZE_SPECIAL_CHARS);
+$rememberMe = Filter::filterVar($request->request->get('faqrememberme'), FILTER_VALIDATE_BOOLEAN);
+$token = Filter::filterVar($request->request->get('token'), FILTER_SANITIZE_SPECIAL_CHARS);
+$userId = (int) Filter::filterVar($request->request->get('userid'), FILTER_VALIDATE_INT);
 
 //
 // Set username via SSO

phpmyfaq/src/phpMyFAQ/Controller/Frontend/UserController.php

@@ -60,7 +60,7 @@ public function updateData(Request $request): JsonResponse
         $password = trim((string) Filter::filterVar($data->faqpassword, FILTER_SANITIZE_SPECIAL_CHARS));
         $confirm = trim((string) Filter::filterVar($data->faqpassword_confirm, FILTER_SANITIZE_SPECIAL_CHARS));
         $twoFactorEnabled = Filter::filterVar($data->twofactor_enabled ?? 'off', FILTER_SANITIZE_SPECIAL_CHARS);
-        $secret = Filter::filterVar($data->secret, FILTER_SANITIZE_SPECIAL_CHARS);
+        $secret = Filter::filterVar($data->secret ?? '', FILTER_SANITIZE_SPECIAL_CHARS);
 
         $isAzureAdUser = $this->currentUser->getUserAuthSource() === 'azure';
         $isWebAuthnUser = $this->currentUser->getUserAuthSource() === 'webauthn';

phpmyfaq/src/phpMyFAQ/Helper/SearchHelper.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * Helper class for phpMyFAQ search.
  *
@@ -17,6 +15,8 @@
  * @since     2009-09-07
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Helper;
 
 use Exception;
@@ -92,7 +92,7 @@ public function createAutoCompleteResult(SearchResultSet $searchResultSet): arra
                 $link = new Link($currentUrl, $this->configuration);
                 $link->setTitle($result->question);
                 $faq = new stdClass();
-                $faq->category = $this->Category->getPath($result->category_id ?? 0);
+                $faq->category = $this->Category->getPath((int) $result->category_id ?? 0);
                 $faq->question = Utils::chopString($question, 15);
                 $faq->url = $link->toString();