test: improved test for downloading the package to make it more robust

Author: thorsten

tests/phpMyFAQ/Setup/UpgradeTest.php

@@ -28,8 +28,19 @@ protected function setUp(): void
      */
     public function testDownloadPackage(): void
     {
-        $actual = $this->upgrade->downloadPackage('3.1.15');
-        $this->assertIsString($actual);
+        if (!$this->isNetworkAvailable()) {
+            $this->markTestSkipped('Network not available');
+        }
+
+        try {
+            $actual = $this->upgrade->downloadPackage('3.1.15');
+            $this->assertIsString($actual);
+        } catch (Exception $e) {
+            if (str_contains($e->getMessage(), 'timeout') || str_contains($e->getMessage(), 'connection')) {
+                $this->markTestSkipped('Network timeout: ' . $e->getMessage());
+            }
+            throw $e;
+        }
 
         $this->expectException('phpMyFAQ\Core\Exception');
         $this->upgrade->downloadPackage('1.2.3');
@@ -87,4 +98,13 @@ public function testGetPathForNonNightly(): void
 
         $this->assertEquals('', $this->upgrade->getPath());
     }
+
+    private function isNetworkAvailable(): bool
+    {
+        $context = stream_context_create([
+            'http' => ['timeout' => 5]
+        ]);
+
+        return @file_get_contents('https://download.phpmyfaq.de', false, $context) !== false;
+    }
 }