fix: corrected weird behaviour that causes loss of configurations

Author: thorsten

phpmyfaq/admin/assets/src/configuration/configuration.ts

@@ -95,6 +95,23 @@ export const handleSaveConfiguration = async (): Promise<void> => {
       const form = document.getElementById('configuration-list') as HTMLFormElement;
       const formData = new FormData(form);
 
+      // Collect all configuration field names that are currently in the form
+      const availableFields: string[] = [];
+      const inputs = form.querySelectorAll('input, select, textarea');
+      inputs.forEach((input: Element): void => {
+        const name = (input as HTMLInputElement).name;
+        if (name && name.startsWith('edit[')) {
+          // Extract the config key from a name like "edit[main.language]"
+          const match = name.match(/edit\[([^\]]+)\]/);
+          if (match) {
+            availableFields.push(match[1]);
+          }
+        }
+      });
+
+      // Add the available fields list to the form data
+      formData.append('availableFields', JSON.stringify(availableFields));
+
       const response = (await saveConfiguration(formData)) as unknown as Response;
 
       if (typeof response.success === 'string') {

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/ConfigurationTabController.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * The Admin Configuration Tab Controller
  *
@@ -17,6 +15,8 @@
  * @since     2023-10-30
  */
 
+declare(strict_types=1);
+
 namespace phpMyFAQ\Controller\Administration\Api;
 
 use phpMyFAQ\Administration\Helper;
@@ -93,6 +93,7 @@ public function save(Request $request): JsonResponse
 
         $csrfToken = $request->request->get(key: 'pmf-csrf-token');
         $configurationData = $request->getPayload()->all(key: 'edit');
+        $availableFieldsJson = $request->request->get(key: 'availableFields');
 
         $oldConfigurationData = $this->configuration->getAll();
 
@@ -103,6 +104,15 @@ public function save(Request $request): JsonResponse
             return $this->json(['error' => Translation::get(key: 'msgNoPermission')], Response::HTTP_UNAUTHORIZED);
         }
 
+        // Parse the list of available fields from the form
+        $availableFields = [];
+        if ($availableFieldsJson) {
+            $availableFields = json_decode($availableFieldsJson, true);
+            if (!is_array($availableFields)) {
+                $availableFields = [];
+            }
+        }
+
         // Set the new values
         $newConfigValues = [];
         $escapeValues = [
@@ -152,10 +162,24 @@ public function save(Request $request): JsonResponse
             }
         }
 
+        // Only process fields that were available in the current form
+        // For checkboxes: if field is available but not in configurationData, set to false
+        // For other fields: keep original value if not in configurationData
+        if (!empty($availableFields)) {
+            foreach ($availableFields as $fieldKey) {
+                if (!array_key_exists($fieldKey, $newConfigValues)) {
+                    // Field was in the form but not submitted (unchecked checkbox)
+                    if (isset($oldConfigurationData[$fieldKey]) && $oldConfigurationData[$fieldKey] === 'true') {
+                        $newConfigValues[$fieldKey] = 'false';
+                    }
+                }
+            }
+        }
+
+        // Keep all values that were not in the available fields (from other tabs)
         foreach ($oldConfigurationData as $key => $value) {
-            $newValueExists = array_key_exists($key, $newConfigValues);
-            if (!$newValueExists) {
-                $newConfigValues[$key] = $value === 'true' ? 'false' : $value;
+            if (!array_key_exists($key, $newConfigValues)) {
+                $newConfigValues[$key] = $value;
             }
         }