refactor: migrated privacy redirect (#3834)

Author: thorsten

phpmyfaq/assets/templates/default/index.twig

@@ -173,7 +173,7 @@
               {% if not isMaintenanceMode %}
                 {% if isPrivacyLinkEnabled %}
                   <li class="nav-item">
-                    <a class="nav-link d-inline-block px-0 pt-1 pb-2" target="_blank" href="{{ urlPrivacyLink }}">
+                    <a class="nav-link d-inline-block px-0 pt-1 pb-2" target="_blank" href="./privacy.html">
                       {{ msgPrivacyNote }}
                     </a>
                   </li>

phpmyfaq/index.php

@@ -639,7 +639,6 @@
     'isOpenQuestionsEnabled' => $faqConfig->get('main.enableAskQuestions'),
     'footerNavigation' => $footerNavigation,
     'isPrivacyLinkEnabled' => $faqConfig->get('layout.enablePrivacyLink'),
-    'urlPrivacyLink' => $faqConfig->get('main.privacyURL'),
     'msgPrivacyNote' => Translation::get(key: 'msgPrivacyNote'),
     'isCookieConsentEnabled' => $faqConfig->get('layout.enableCookieConsent'),
     'cookiePreferences' => Translation::get(key: 'cookiePreferences'),

phpmyfaq/privacy.php

@@ -101,7 +101,6 @@ protected function getHeader(Request $request): array
             'isOpenQuestionsEnabled' => $this->configuration->get('main.enableAskQuestions'),
             'footerNavigation' => $this->getFooterNavigation($request),
             'isPrivacyLinkEnabled' => $this->configuration->get('layout.enablePrivacyLink'),
-            'urlPrivacyLink' => $this->configuration->get('main.privacyURL'),
             'msgPrivacyNote' => Translation::get(key: 'msgPrivacyNote'),
             'isCookieConsentEnabled' => $this->configuration->get('layout.enableCookieConsent'),
             'cookiePreferences' => Translation::get(key: 'cookiePreferences'),

phpmyfaq/src/phpMyFAQ/Controller/Frontend/AbstractFrontController.php

@@ -0,0 +1,41 @@
+<?php
+
+/**
+ * Privacy Controller
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public License,
+ * v. 2.0. If a copy of the MPL was not distributed with this file, You can
+ * obtain one at https://mozilla.org/MPL/2.0/.
+ *
+ * @package   phpMyFAQ
+ * @author    Thorsten Rinne <[email protected]>
+ * @copyright 2023-2026 phpMyFAQ Team
+ * @license   https://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
+ * @link      https://www.phpmyfaq.de
+ * @since     2023-01-22
+ */
+
+declare(strict_types=1);
+
+namespace phpMyFAQ\Controller\Frontend;
+
+use Symfony\Component\HttpFoundation\RedirectResponse;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Attribute\Route;
+
+final class PrivacyController extends AbstractFrontController
+{
+    /**
+     * Redirects to the privacy page stored in the configuration.
+     * @throws \Exception
+     */
+    #[Route(path: '/privacy.html', name: 'public.privacy')]
+    public function index(Request $request): Response
+    {
+        $privacyUrl = $this->configuration->get('main.privacyURL');
+        $redirectUrl = strlen((string) $privacyUrl) > 0 ? $privacyUrl : $this->configuration->get('main.referenceURL');
+
+        return new RedirectResponse($redirectUrl);
+    }
+}

phpmyfaq/src/phpMyFAQ/Controller/Frontend/PrivacyController.php

@@ -18,10 +18,15 @@
 declare(strict_types=1);
 
 use phpMyFAQ\Controller\Frontend\Api\SetupController;
-use phpMyFAQ\Controller\Frontend\AttachmentController;use phpMyFAQ\Controller\Frontend\ContactController;
-use phpMyFAQ\Controller\Frontend\GlossaryController;use phpMyFAQ\Controller\Frontend\LoginController;use phpMyFAQ\Controller\Frontend\OverviewController;
+use phpMyFAQ\Controller\Frontend\AttachmentController;
+use phpMyFAQ\Controller\Frontend\ContactController;
+use phpMyFAQ\Controller\Frontend\GlossaryController;
+use phpMyFAQ\Controller\Frontend\LoginController;
+use phpMyFAQ\Controller\Frontend\OverviewController;
 use phpMyFAQ\Controller\Frontend\PageNotFoundController;
-use phpMyFAQ\Controller\Frontend\PdfController;use phpMyFAQ\Controller\Frontend\SitemapController as FrontendSitemapController;
+use phpMyFAQ\Controller\Frontend\PdfController;
+use phpMyFAQ\Controller\Frontend\PrivacyController;
+use phpMyFAQ\Controller\Frontend\SitemapController as FrontendSitemapController;
 use phpMyFAQ\Controller\Frontend\WebAuthnController;
 use phpMyFAQ\Controller\LlmsController;
 use phpMyFAQ\Controller\RobotsController;
@@ -67,6 +72,11 @@
         'controller' => [PdfController::class, 'index'],
         'methods' => 'GET',
     ],
+    'public.privacy' => [
+        'path' => '/privacy.html',
+        'controller' => [PrivacyController::class, 'index'],
+        'methods' => 'GET',
+    ],
     'public.sitemap' => [
         'path' => '/sitemap/{letter}/{language}.html',
         'controller' => [FrontendSitemapController::class, 'index'],