Skip to content

Commit d61d89c

Browse files
authored
fix: handling for search term (#3806)
Unifying the search on form method="get" to make search results accessible for bookmarks and sharing via link. fix that results available on normal and advanced search
1 parent 0552e5b commit d61d89c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

phpmyfaq/assets/templates/default/index.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
<div class="row height d-flex justify-content-center align-items-center">
107107
<div class="col-md-8">
108108
<div class="search">
109-
<form action="./search.html" id="search" method="post" role="search">
109+
<form action="./search.html" id="search" method="get" role="search">
110110
<i class="bi bi-search"></i>
111111
<input autocomplete="off" type="text" class="form-control form-control-lg" id="pmf-search-autocomplete"
112112
name="search" placeholder="{{ searchBox }} ..." maxlength="255" value="{{ searchTerm }}">

phpmyfaq/search.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
$request = Request::createFromGlobals();
6161
$inputLanguage = Filter::filterVar($request->query->get('pmf-all-languages'), FILTER_SANITIZE_SPECIAL_CHARS);
6262
$inputCategory = Filter::filterVar($request->query->get('pmf-search-category'), FILTER_VALIDATE_INT, '%');
63-
$inputSearchTerm = Filter::filterVar($request->request->get('search'), FILTER_SANITIZE_SPECIAL_CHARS);
63+
$inputSearchTerm = Filter::filterVar($request->query->get('search'), FILTER_SANITIZE_SPECIAL_CHARS);
6464
$inputSearchTerm = Strings::substr($inputSearchTerm, 0, 255);
6565
$inputTag = Filter::filterVar($request->query->get('tagging_id'), FILTER_SANITIZE_SPECIAL_CHARS);
6666

0 commit comments

Comments
 (0)