fix: corrected plural handling in Arabic

Author: thorsten

composer.lock

@@ -1,6 +1,4 @@
-<?php
-
-declare(strict_types=1);
+<?php declare(strict_types=1);
 
 /**
  * The plural class provides support for plural forms in phpMyFAQ translations.
@@ -64,6 +62,13 @@ private function plural(string $language, int $number): int
     {
         switch ($language) {
             case 'ar':
+                // Arabic has 6 plural forms following GNU gettext standard:
+                // Form 0: zero (n==0)
+                // Form 1: one (n==1)
+                // Form 2: two (n==2)
+                // Form 3: few (n%100>=3 && n%100<=10) - e.g., 3, 10, 103, 210
+                // Form 4: many (n%100>=11 && n%100<=99) - e.g., 11, 99, 111, 199
+                // Form 5: other (everything else) - e.g., 100, 101, 102, 200, 1000
                 if ($number === 0) {
                     return 0;
                 }
@@ -77,7 +82,7 @@ private function plural(string $language, int $number): int
                 if ($n100 >= 3 && $n100 <= 10) {
                     return 3;
                 }
-                if ($n100 >= 11 || $n100 === 1 || $n100 === 2) {
+                if ($n100 >= 11 && $n100 <= 99) {
                     return 4;
                 }
                 return 5;

phpmyfaq/src/phpMyFAQ/Language/Plurals.php

@@ -147,8 +147,8 @@ public static function preg_match_all(
     /**
      * Split string by a regexp.
      */
-    public static function preg_split(string $pattern, string $subject, int $limit = -1, int $flags = 0): array|bool // phpcs:ignore
-    {
+    public static function preg_split(string $pattern, string $subject, int $limit = -1, int $flags = 0): array|bool
+    { // phpcs:ignore
         return self::$instance->preg_split($pattern, $subject, $limit, $flags);
     }
 

phpmyfaq/src/phpMyFAQ/Strings.php

@@ -111,6 +111,44 @@ public function testPluralFormsArabic(): void
         $this->assertEquals(5, $this->pluralMethod->invoke($this->plurals, 'ar', 100));
     }
 
+    /**
+     * Test Arabic plural edge cases including numbers ending in 01-02
+     * @throws \ReflectionException
+     */
+    public function testArabicPluralEdgeCases(): void
+    {
+        // Form 0: zero
+        $this->assertEquals(0, $this->pluralMethod->invoke($this->plurals, 'ar', 0));
+
+        // Form 1: one
+        $this->assertEquals(1, $this->pluralMethod->invoke($this->plurals, 'ar', 1));
+
+        // Form 2: two
+        $this->assertEquals(2, $this->pluralMethod->invoke($this->plurals, 'ar', 2));
+
+        // Form 3: 3-10 (last two digits)
+        $this->assertEquals(3, $this->pluralMethod->invoke($this->plurals, 'ar', 3));
+        $this->assertEquals(3, $this->pluralMethod->invoke($this->plurals, 'ar', 10));
+        $this->assertEquals(3, $this->pluralMethod->invoke($this->plurals, 'ar', 103));
+        $this->assertEquals(3, $this->pluralMethod->invoke($this->plurals, 'ar', 110));
+        $this->assertEquals(3, $this->pluralMethod->invoke($this->plurals, 'ar', 203));
+
+        // Form 4: 11-99 (last two digits)
+        $this->assertEquals(4, $this->pluralMethod->invoke($this->plurals, 'ar', 11));
+        $this->assertEquals(4, $this->pluralMethod->invoke($this->plurals, 'ar', 99));
+        $this->assertEquals(4, $this->pluralMethod->invoke($this->plurals, 'ar', 111));
+        $this->assertEquals(4, $this->pluralMethod->invoke($this->plurals, 'ar', 199));
+
+        // Form 5: 100, 101, 102, etc.
+        $this->assertEquals(5, $this->pluralMethod->invoke($this->plurals, 'ar', 100));
+        $this->assertEquals(5, $this->pluralMethod->invoke($this->plurals, 'ar', 101));
+        $this->assertEquals(5, $this->pluralMethod->invoke($this->plurals, 'ar', 102));
+        $this->assertEquals(5, $this->pluralMethod->invoke($this->plurals, 'ar', 200));
+        $this->assertEquals(5, $this->pluralMethod->invoke($this->plurals, 'ar', 201));
+        $this->assertEquals(5, $this->pluralMethod->invoke($this->plurals, 'ar', 202));
+        $this->assertEquals(5, $this->pluralMethod->invoke($this->plurals, 'ar', 1001));
+    }
+
     /**
      * @throws \ReflectionException
      */