Skip to content

lack of support macos not supported #1104

@ssbarnea

Description

@ssbarnea

I only understood much later that this tool works only on Linux as that was not obvious from its description.

$ thamos config         
2022-04-08 14:34:58,016 [61403] INFO     thamos: No configuration file found, creating one from a configuration template from a default template
2022-04-08 14:34:58,016 [61403] INFO     thamos.config: Discovering host runtime environment
2022-04-08 14:34:58,016 [61403] ERROR    thamos.discover: Failed to obtain CPU specific information: [Errno 2] No such file or directory: '/proc/cpuinfo'
Traceback (most recent call last):
  File "/Users/ssbarnea/.pyenv/versions/3.10.3/lib/python3.10/site-packages/thamos/discover.py", line 98, in discover_cpu
    with open(_PROC_CPU_INFO, "r") as cpu_info_file:
FileNotFoundError: [Errno 2] No such file or directory: '/proc/cpuinfo'
/bin/sh: edit: command not found
2022-04-08 14:34:58,044 [61403] ERROR    thamos: edit: Editing failed
FAIL: 1

The reality is that most people using python expect to see tools working on any POSIX system, including MacOS. If you happen not use have/use a mac, you can use BSD as close enough system to test against, as if you get it working on BSD, it will almost for sure work on MacOS.

If there is no desire to make it work on macos, at least Linux should be mentioned as part of the first sentence in product description, if not even the title itself. Also, adding a nice error message at cli would provide a better experience than a delayed tracedump.

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.priority/backlogHigher priority than priority/awaiting-more-evidence.sig/user-experienceIssues or PRs related to the User Experience of our Services, Tools, and Libraries.triage/acceptedIndicates an issue or PR is ready to be actively worked on.triage/needs-informationIndicates an issue needs more information in order to work on it.

    Type

    No type

    Projects

    Status

    📋 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions