@@ -14,21 +14,109 @@ will need to follow the steps for reviewing usage examples.
1414
1515When reviewing an example, follow these steps:
1616
17- 1 . Test each code file on your machine.
18- 2 . Check the structure and functionality of the code in each language.
19- 3 . Review the preview on the website.
17+ ### 1. Test the code
2018
21- If there are any issues comment on the pull request with the necessary changes. Once those changes
22- are made, then use the following template as your comment in the pull request.
19+ Compile/run each code file on your machine.
2320
24- ``` shell
21+ - Are there any errors?
22+ - Are there any warnings?
23+ - Does the program run as expected?
24+
25+ ### 2. Analyse the effectiveness
26+
27+ Consider the function being demonstrated and how it might be used by a SplashKit user.
28+
29+ - Does the code example demonstrate the usefulness of the function?
30+ - Or, do the code example give more insight into how the function works?
31+ - Is the example simple enough for an SIT102 or SIT771 student to follow, while still being an
32+ interesting example?
33+
34+ ### 3. Compare and analyse the code
35+
36+ Check the structure and functionality of the code in each language.
37+
38+ - Does the sequence of code match for all code files?
39+ - Do the code comments match across all code files?
40+ - Does the code follow the
41+ [ style guide] ( /products/splashkit/splashkit-website/usage-examples/05-usage-example-style-guide )
42+ requirements?
43+ - Is the Object Oriented C# code using the Object Oriented format where possible/relevant?
44+ - Is the python code using the correct function names? (These function names will often differ from
45+ other languages due to python not handling function overloads)
46+
47+ ### 4. Test in localhost
48+
49+ Check the example displays correctly in your local development environment.
50+
51+ - Does the website build successfully with ` npm run build ` ?
52+ - Does the example display under the correct function when previewing the website with
53+ ` npm run preview ` ?
54+ - Is the correct function highlighted in the example code?
55+
56+ ### 5. Request changes
57+
58+ Add your review comments on the pull request on GitHub.
59+
60+ - Add comments for individual lines, or groups of lines in the code files. This helps the original
61+ contributor to understand exactly what the issue is related to.
62+ - Use professional language, and be polite but assertive.
63+ - Include the correct version of code where relevant, or any suggested improvements.
64+ - Ask questions if something is confusing or unclear.
65+
66+ :::note
67+
68+ ** First Peer Review:**
69+
70+ - It is _ very unlikely_ that you will approve a pull request on first review without any changes.
71+ - We all miss things in our own code, which is why peer reviews are so important.
72+
73+ ** Second Peer Review:**
74+
75+ - This review is more likely to be able to be approved without changes being requested.
76+ - However, it is important to check that the first reviewer did not miss anything that _ should have
77+ been found_ in the first review.
78+ - You might also have experience that allows you to consider other aspects that the first reviewer
79+ would not have noticed.
80+
81+ :::
82+
83+ ### 6. Continue discussion about changes on the pull request
84+
85+ Check for replies on the pull request from the original contributor.
86+
87+ - These comments might be requesting more information about your suggested changes, so it is
88+ important to respond quickly.
89+ - Discussions may include some debate on the best way forward. Be open to the ideas suggested by the
90+ other person, and include evidence to back up your reasoning.
91+ - If needed, either the reviewer or the original contributor can reach out to your Mentor to help
92+ decide what the outcome should be.
93+ - Check for a comment from the original contributor that the requested changes have been made.
94+
95+ ### 7. Review the pull request again
96+
97+ Repeat steps 1 - 4 above.
98+
99+ - It is important to review the pull request thoroughly to ensure that the changes have not caused
100+ other issues.
101+ - You may notice other issues once changes have been made. This is okay, and is part of the
102+ development process.
103+ - Ensure that the pull request will be able to be merged upstream to the live site before you
104+ approve it.
105+
106+ ### 8. Approve the pull request
107+
108+ Once all the requested changes have been made, approve the pull request using the following template
109+ in the comment of the approving review:
110+
111+ ``` plaintext
25112# Peer Review
26113
27114I've reviewed the ...
28115
29- # Checks
116+ ## Checks
117+
30118- [ ] All required files are present.
31- - [ ] Title and explanation (.txt)
119+ - [ ] Example Title (.txt)
32120 - [ ] C++ code (SplashKit)
33121 - [ ] C# code (top-level statements)
34122 - [ ] C# code (Object-Oriented Programming)
@@ -39,12 +127,18 @@ I've reviewed the ...
39127- [ ] Code clearly demonstrates the function.
40128- [ ] All versions maintain the same structure and comments.
41129
42- # Tests done
130+ ## Code Tests done
131+
43132- [ ] C++ SplashKit code ran correctly.
44133- [ ] C++ Beyond SplashKit code ran correctly.
45134- [ ] C# top level code ran correctly.
46135- [ ] C# OOP code ran correctly.
47136- [ ] Python code ran correctly.
137+
138+ ## Website Tests done
139+
140+ - [ ] npm run build
141+ - [ ] npm run preview
48142```
49143
50144Ensure while doing peer reviews that you also follow the
0 commit comments